Error when trying to compile about samplableset HOT 6 CLOSED

Hey Ben, no problem, I am happy to see this package can be useful to others!

This thread made me think it could be an issue with clang and c++17 features, however I just tested it with clang++ 10.0.0 and everything was fine. What version are you using? Have you been able to use c++17 features before?

from samplableset.

hmm, no, not that I know of. As of your setup script, clang++ is tested for its c++17 features and doesn't raise an error. I'm using clang++ v10.0.1. I've just had my student try to install it on her machine and she got the same errors (with clang++ v11.0.0 on macOS 10.15.1). All of the errors above hint at constructors being private, maybe that's a new feature of the Apple compiler?

from samplableset.

ok, so I got it to compile by replacing every instance of iterator_(NULL) with iterator_(). These are all occurrences:

./SamplableSetCR.hpp:119:    iterator_(NULL),
./SamplableSetCR.hpp:144:    iterator_(NULL),
./SamplableSetCR.hpp:161:    iterator_(NULL),

I have no idea what I did there and whether it was dangerous or correct to do so, though, haha.

I've followed this thread, basically: personalrobotics/appl#1 (cites this: personalrobotics/appl@e433ee6)

from samplableset.

Excellent! No I don't think this should be a problem. I'll run some test just to be sure, then push a an update.

from samplableset.

Alright, this should work now with #18. Thanks for raising the issue!

from samplableset.

awesome! thanks for the quick replies :)

from samplableset.