gruppler / ptn-ninja Goto Github PK

After making some changes and then undoing them, further changes and undos sometimes don't work.

https://getmdl.io/started/index.html

It seems that if you start at the end of the game and navigate backwards through the PTN and then trim to the current board then the active player will swap - e.g. for a given position it’ll go from Black being active to White being the active player.

I think both the moves pane on the left and the notes pane on the right are strong tools. Right now I don't use the notes because then I cannot see the moves anymore. Instead I write down notes somewhere else. If they where both visible at the same time, I think that would be great!

Test to verify this is worth it.

I don't want to turn this into a playtak.com competitor, but I want to give it simple peer-to-peer networking so you can share a link with someone and play a private, non-timed game.

I'd also like to allow users to play existing bots.

Describe the bug
When resizing the browser window to the minimum possible height and then opening it up to a more usable height, the board is broken.

To Reproduce
Steps to reproduce the behavior:

1. Create a game (seems to work with empty/full)
2. Resize browser to height=0
3. Resize browser back to an normal height
4. Board is now broken
5. Try to switch between different games: Still broken

Expected behavior
Changing the height to 0 and back should not change how the board looks like.

Screenshots

Desktop:

• OS: Microsoft Windows 10 Pro 10.0.19042 N/A Build 19042
• Browser: Chrome
• Version 88.0.4324.104 (Official Build) (64-bit)

Played pieces aren't showing up on the board although road highlighting confirms that they are actually there. Same problem on both Safari and Chrome, latest versions of everything. Clearing cookies didn't help.

playtak.com's games now have a TimeControl tag to indicate timer information. This breaks the site. You can maybe ignore unknown tags?

I find myself really missing (from the ptnviewer fiddle) the ability to step through the game in read-only mode with the notation side-by-side with the board. It's useful to be able to see move numbers and notation when commenting on a game or reading a game that is commented elsewhere.

• Play Mode:
  • Highlight squares
  • Show annotations
  • Play speed
• Edit Mode:
  • Highlight squares
  • Show parse errors
  • Board opacity
  • Trim to current ply
    • Encode current board as TPS and add to header
    • Remove preceding notation
  • Automatic Formatting:
    • Styles:
      • Verbose
        • Insert all stone types (before place, after slide)
        • Insert all slide and drop counts
      • Minimal
        • Opposite of Verbose
    • Toggle: Pad line numbers
      • Pad between plies based on longest ply1
    • Automatically insert analytical notation
      • Use TakAnalysis by nqeron
• Board:
  • Animate Board
  • Axis Labels
  • Player Scores
  • Current Move
  • Unplayed Pieces
  • Play Controls
  • Road Connections
• Game Properties
  • Open modal dialog to view or edit tags
• Permalink
• Embed
• Download
• Open
• Load sample game
• Load stress test
• About
  • Modal readme.md

I'm having trouble reproducing this, and it may be a browser rendering bug, but sometimes when switching from side-by-side layout to single column, the board doesn't become translucent.

Describe the bug
The embed modal is empty after refreshing the page.

To Reproduce
Steps to reproduce the behavior:

1. Go to e.g. this board on ptn.ninja
2. Click on share->embed
3. Press F5
4. See that the embedded board in the modal is no longer there

Expected behavior
After pressing F5 the modal should either look the same as before or not open at all.

Screenshots

Desktop:

• OS: Microsoft Windows 10 Pro 10.0.19042 N/A Build 19042
• Browser: Chrome
• Version 88.0.4324.104 (Official Build) (64-bit)

Also:

• I didn't spot any errors in the dev console aside from:

  3.c3e6a041.js:1 Error: Cannot find module './en-gb/about.md'
      at 3.c3e6a041.js:1
  3.c3e6a041.js:1 Error: Cannot find module './en-gb/usage.md'
      at 3.c3e6a041.js:1
  

• I cleared localStorage and could reproduce the problem on an empty 5x5 board as well

This must be scroll-target="#notes-scroll-area > .scroll"

This must be scroll-target="#ptn-scroll-area > .scroll"

Useful for when using ptn.ninja links for async play (e.g. play-by-email, play-by-IM).
It would be great to show the remaining piece count and/or the flat score to evaluate a possible flat victory without having to count stones

Description
The reload required to get an updated version of the code base uses the local storage copy of the PTN rather than the PTN that should have just overwritten it.

Repro Steps:

1. Have a game in memory.
2. Have an out-of-date version of the files served from the server.
3. Follow a link to a game of the same name as the game in step 1, but with different PTN.
4. Get a pop up to update.
5. Click the refresh button in the update.

Actual Behavior
The old PTN is displayed on the board and appears to be in local storage.

Expected Behavior
After reload, the new PTN should be displayed on the board and be saved in local storage.

Environment

• OS: Tested on iOS and Windows
• Browser: Chrome
• Version: Latest

The embedded <iFrame> that I'm using for my blog appear blank when using Chrome on iOS.

It would be nice when in play mode to be able to see the current count of each player's remaining pieces, as this is often relevant to the game, making it clear if one player can start forcing a flat win or not.

Counting the pieces on the board is annoying and most people (especially me) are bad at doing it.

vs

this works:

this is on Chrome 52 on Mac, on ptn.ninja

I have found a bug where the editor is corrupted due to weird alternate line stuff. I have two pictures. To reproduce: Play a few moves in a PTN game (or find an old game). Find a position where white or black captures a piece the turn after which it is placed. (e.g. 4. d4 e4<). Then use the navigation arrows to wind back to the placement and replace it with a noble (I know this works with a wall and am assuming it will with a capstone). Then play one more move with the color that would have done the capture. (unknown atm if this will reproduce will more moves, but fairly likely) Then go to the editor and note that the alternative lines are off and incorrect. If you edit anything - even the name of a player it should start complaining about illegal moves.

Ideally, I'd like to produce a short duplication video, but I don't have the time atm, so I'm hoping this will be sufficient.

It seems to me that the way the comments display is off by one - that is, they appear before the annotated move is placed on the board. For example
shows the annotation for the upcoming move rather than the one just played (f6 {adjacent corners}).

Can this be tweaked?

I'm not sure if this is a PTN ninja issue or a playtak issue or both, but when I click the ptn.ninja link on a given game from the history page of playtak on my iPhone it brings me to a blank game, rather than loading in the game on file.

The bottom left of a chessboard (a1) is always black, but you consistently use white. Is this intentional? Or can you change it (or leave it to be an option?).

Describe the bug
When you try to enter TPS mode while creating a new game, it enters TPS mode on the previous game and creates a new game where you are not in TPS mode. This then lets you break the previous game completely since you can enter TPS mode while there are also existing plies on the board.

To Reproduce
Steps to reproduce the behavior:

1. Go to New Game
2. Click Edit on TPS
3. Observe how you are not in TPS mode
4. Check the game you just left, see that you are in TPS mode (sometimes you just get stuck loading the game)

Expected behavior
I except to enter TPS mode for the new game, not the previous one.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Firefox
• Version: 102.0.1 (64-bit)

Additional context
Discord message: https://discord.com/channels/176389490762448897/361023655465058307/1001873075425517618

I will look into automatically marking Tak and Tinuë, as well as detecting a game end.

PTN Ninja

In navigating this game, I can navigate to the end, but then have an issue navigating back to the beginning of the timeline.

Prompt for board size when starting a new game.

I'm having trouble reproducing this one, but sometimes when I undo, it seems I can't go all the way to the original state, just one change before it.

Can we get a function to Trim to the current ply, also getting rid of all the successive moves, boiling the board down to a specific TPS?

I tried opening ptn.ninja with the new changes on Safari on iOS, but saw nothing.

• Open in new window
• Input aspect ratio OR width and height
  • Inputs update on resize
• Option to include current ply ID in URL
• Allow initial (edit/play) mode override
• Allow preference override
  • Presets:
    • Current Board Only (Screenshot Mode)
      • Include only TPS in URL hash
    • Minimal Play Mode
    • Maximal Play Mode

Describe the bug
The embed preview is

1. missing the player names.
2. not padding white's flat-count enough when it has 2 digits

To Reproduce
Steps to reproduce the behavior:

1. Create a new game
2. Drop enough flats so that white has a 2-digit flat-count or just click here
3. Click on share->embed

Expected behavior

1. White's flat count should have the same padding-right as black's has padding-left

Screenshots

Desktop:

• OS: Microsoft Windows 10 Pro 10.0.19042 N/A Build 19042
• Browser: Chrome
• Version 88.0.4324.104 (Official Build) (64-bit)

• Game info view dialog (for embed and online spectating)
• Reorganize hotkeys
• Refactor Main and Embed layouts
• Update documentation

• Restructure online games and chats
• Push notifications
• Player chat
• Spectator chat
• Private scratchpad
  • Optionally auto-respond
• Rethink UI for Play Mode
• "Send" button to commit ply
• History navigation consensus

playtak-generated PTNs have a [Clock] section which ptn.ninja says is invalid. An example line is [Clock "10:0 +15"] for a game with 10 minutes +15s add

This is especially annoying since the US Tak Open is going on right now and ptn.ninja is really nice to use for sharing games

• Use window.postMessage
• Send and/or receive in JSON:
  • Raw PTN text
  • Compressed PTN
  • Parsed PTN
  • Current board TPS
  • PTN changes
  • Highlight square(s)
    • By square
    • By ply
  • Navigation events:
    • Previous
    • Next
    • Ply by ID
    • Move by ID
  • Single ply (to be) performed
    • Errors from Board.do_ply()
  • Errors from Game.parse()
  • Message to be displayed
    • Types:
      • success
      • warning
      • error
      • help
      • info
      • comment
      • player1
      • player2

• Styles:
  • Verbose
    • Insert all stone types (before place, after slide)
    • Insert all slide and drop counts
  • Minimal
    • Opposite of Verbose
• Toggle: Pad line numbers
• Pad between plies based on longest ply1

I tried navigating to a game from the play tak history viewer using the PTN ninja link, and it wasn't working. (Chrome - Mac OS X)

Describe the bug

The ply for the top of an alternate branch is showing instead of the appropriate one.

To Reproduce

Create a game with multiple branches and steps of those branches.
Manually rewind to the fork
Manually take a previously explored alternate.
In the top, where the plies are, the previous branches' ply is listed instead of the correct one.

Is your feature request related to a problem? Please describe.
On a smartphone screen, the unplayed pieces take up valuable horizontal space, so the board is smaller than it needs to be.

Describe the solution you'd like
Adding an option (or maybe even making it the default on small screens) to move the unplayed pieces somewhere else than next to the board would help. E.g. rotating them 90° and putting them above and/or below the board, where there's plenty of unused space.

Describe alternatives you've considered
There's already an option to hide unplayed pieces entirely, but that's not an ideal solution imo.

Additional context
Here's a screenshot to clarify what I mean:

I like to always have the game notation open when I study a game, so I can always have my bearings straight, but currently it's impossible to navigate through moves easily when the game notation is open—clicking on each move individually with the cursor is rather cumbersome. Even a simple forward and backward arrow functionality from the notation screen would be fine, but I think it also might be useful to be able to view the notation in a mode where it is not opened in text-editing mode. As I said, I always want to be able to see the notation, but seldom do I want to edit it. Thank you for your consideration.

Under both Linux and Windows 10. Everything works fine under Chrome on the same computer, and it all worked fine on previous versions of Firefox. I'm sure this is related to the recent release of Firefox Quantum.

It's slow and unintuitive.

• Show all possible tags
• Indicate required tags
• Inputs provide options or format validation