grundprinzip / gerrit-check Goto Github PK

There should be an easy way, e.g. via an external file, to configure the options / command line arguments passed to the individual checkers.

gerrit-check package in pip https://pypi.org/project/gerrit-check/ is out of date with master branch. It missed all fixes.

I have this error when running the gerrit-check command:
Traceback (most recent call last): File "/usr/local/bin/gerrit-check", line 9, in <module> load_entry_point('gerrit-check==0.1.1', 'console_scripts', 'gerrit-check')() File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 351, in load_entry_point return get_distribution(dist).load_entry_point(group, name) File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2363, in load_entry_point return ep.load() File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2088, in load entry = __import__(self.module_name, globals(),globals(), ['__name__']) File "/usr/local/lib/python2.7/dist-packages/gerritcheck/check.py", line 18, in <module> from flake8.engine import get_style_guide ImportError: No module named engine

I installed gerrit-check using pip.

Python version 2.7.6
Ubuntu 14.04.5 LTS

I have the same error when installing it on windows.

Using gerrit-check, I get frequent false positives about struct members being unused, even though they are clearly being used in .cpp implementation files, and checking those files directly will not find an issue.
It turns out that the way check.py includes header files for passing to cppcheck is wrong.
In fact this is confirmed on http://stackoverflow.com/questions/36825903/cppcheck-claims-that-a-field-is-not-used-while-it-is-in-another-file

Header files should not be explicitly checked, but are implicitly checked.
Therefore check.py, line 28 should be changed to not include .h and .hpp files.