grondag / clear-skies Goto Github PK

View Code? Open in Web Editor NEW

42.0 42.0 4.0 3.18 MB

Horizon and fog match the sky color. True blue skies!

Home Page: https://www.curseforge.com/minecraft/mc-mods/clear-skies

License: GNU Lesser General Public License v3.0

Java 71.14% Shell 28.86%

clear-skies's People

Contributors

Stargazers

Watchers

Forkers

booky10 superloach matty45 violetmistclouddrift

clear-skies's Issues

Playing with Origins mod causes visual/rendering bug at night.

When playing as the Feline origin in the Origins mod, it causes the rendering bug pictured below. This happens only at night, presumably when the Nocturnal power is supposed to activate. This bug can be reproduced on a fresh 1.16.1 fabric install with just Origins (0.3.4) and Clear Skies (1.4.44) mod installed. Use the command /time set 13500 and wait a few seconds for the bug to appear. There's already an issue on this on the Origins mod's repository here.

Subtle banding when moon and sun both in sky

From CF: Looks great! I did notice an issue on 1.16.1 though. When only the sun or the moon is in the sky, it works perfect! yet when both are in the sky at the same time, the transitions are still weird, almost favoring the lower celestial body, while neglecting the higher celestial body, until it becomes fully day (or night). Is this re-create-able and fixable? I'm going to follow this mod. I searched all 64 pages of fabric mods lol, and along the way, you're the only one to attempt this. See what you can do?

Clear Skies crashes in 1.19.

When attempting to load up any worlds in 1.19, Clear skies would just crash the client instead.

1.20(.1)?

title

1.19.4

If it is already compatible, please mark it as such on modrinth and curseforge and if not, then please update it
Thanks

[1.16.4] Night Vision at night makes everything black

When using this mod and applying night vision while it's night makes everything completely black. The blocks? Black. Mobs? Black. Items in inventory? Black. Text in options screen? Black. It looks exactly like MC-165208

Don't do separate GitHub releases for separate loaders.

GitHub releases are always considered sequential, so on the outside it looks like you don't have a Fabric release, because the Forge release is considered the latest release and is shown on your repo's "Releases" widget. Instead, bundle them into the same release with different filenames.

1.18.1 Port works in 1.18.1, but not 1.18

Title pretty much says it all. Sorry for not being able to provide any more information.

Add support for Minecraft 1.18.2

Incompatible with VoxelMap 1.10.7

Both mods attempt to redirect onGetHorizontalPlaneDot, but due to this not being possible (presumably, since the log warns and then throws an exception), and presumably due to Clear Skies having require = 1 set in the redirect, the game crashes upon startup.

Exception log:

[23:05:09] [main/WARN]: @Redirect conflict. Skipping clear-skies.client.json:MixinBackgroundRenderer->@Redirect::onGetHorizontalPlaneDot(Lnet/minecraft/class_1160;Lnet/minecraft/class_1160;)F with priority 1000, already redirected by mixin.voxelmap.json:ONMixinBackgroundRenderer->@Redirect::onDotProduct(Lnet/minecraft/class_1160;Lnet/minecraft/class_1160;)F with priority 1000
[23:05:09] [main/INFO]: [STDERR]: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector onGetHorizontalPlaneDot(Lnet/minecraft/class_1160;Lnet/minecraft/class_1160;)F in clear-skies.client.json:MixinBackgroundRenderer failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap clear-skies-refmap.json
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:400)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1280)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1042)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:395)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:320)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:345)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:570)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:351)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:191)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:178)
[23:05:09] [main/INFO]: [STDERR]: 	at org.spongepowered.asm.mixin.transformer.FabricMixinTransformerProxy.transformClassBytes(FabricMixinTransformerProxy.java:23)
[23:05:09] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:157)
[23:05:09] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:143)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
[23:05:09] [main/INFO]: [STDERR]: 	at net.minecraft.class_310.method_1523(class_310.java:1012)
[23:05:09] [main/INFO]: [STDERR]: 	at net.minecraft.class_310.method_1514(class_310.java:654)
[23:05:09] [main/INFO]: [STDERR]: 	at net.minecraft.client.main.Main.main(Main.java:215)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[23:05:09] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:192)
[23:05:09] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:140)
[23:05:09] [main/INFO]: [STDERR]: 	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[23:05:09] [main/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
[23:05:09] [main/INFO]: [STDERR]: 	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
[23:05:09] [main/INFO]: [STDERR]: 	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
[23:05:09] [main/INFO]: [STDERR]: 	at org.multimc.EntryPoint.listen(EntryPoint.java:143)
[23:05:09] [main/INFO]: [STDERR]: 	at org.multimc.EntryPoint.main(EntryPoint.java:34)
[... likely irrelevant unreported exception stuff skipped]
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector onGetHorizontalPlaneDot(Lnet/minecraft/class_1160;Lnet/minecraft/class_1160;)F in clear-skies.client.json:MixinBackgroundRenderer failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap clear-skies-refmap.json

I've noticed that Clear Skies still seems to work correctly if require is set to 0 on this particular redirect in MixinBackgroundRenderer.java, but I don't know enough about coding Minecraft mods to say if that's the "correct" solution or not.

System info:
Java 15-ea & 8 (1.8.0_252)
Minecraft 1.16.1
Fabric Loader 0.9.0+build.204

Mods in use:
Clear Skies 1.4.43 from CurseForge (and self-built, but I tested against the CurseForge release as well)
VoxelMap 1.10.7 (unsure if it's all versions or just this one, I tend to only use the latest versions of mods)

Steps to reproduce:
-Install Clear Skies
-Install VoxelMap
-Launch the Game
-Observe the crash

If any further info would help, please let me know.

Chinese Name

Could translate the Mod name to "洁净天空" ?

Doesn't Work With Colormatic

Multiplayer menu says incompatible with forge server

please make this not required on server-side its confusing for clients trying to join a forge server to be told its incompatible

[12Jul2022 22:30:28.751] [Netty Client IO/INFO] [net.minecraftforge.client.ForgeHooksClient/CLIENTHOOKS]: Client has mods that are missing on server: [clear_skies]

Early acces to releases in Github

In my opinion adding already ready releases to the Github releases page before Modrinth and CurseForge accepts them, would be a good idea. I have been waiting for 1.20.x version of Clear Skies pretty long time now and because in this reply you said it is only waiting for approval from Modrinth and CurseForge, i hope you will consider this idea.

P.S. Sorry for my perhaps bad English and thanks for developing such a great mod.

EDIT: Corrected some typos

CurseForge mark on Clear Skies compitable with 1.19.2

Hello, please put a note on CurseForge that it is compatible with 1.19.2, I need it for the Modpack.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.