grillbiff / draganddroptableview Goto Github PK

When call deleteRowsAtIndexPaths (tableview has only one row, so row count 1 ==> 0, if success), app crashed.

Hello @grillbiff
At my code, there are many changes insert/delete action to tableview while dragging (background processing).

I used [UITableView beginUpdate and endUpdate], and added NSLock lock] before beginUpdate, end unLock after endUpdate to prevent crash.

But your code call reloadData after release press,
So, my app crashes sometimes.
Can you avoid using reloadData?

After drop,I think, it is not needed to call reloadData , or if need, it may be replaced by insert/deleteRows nested by begin/endUpdate.

I have added a crash callstack screenshot.

Thank you.

moveRowAtIndexPath isn't called when moving some row to 0th section which doesn't have any row at the moment!! You demo project doesn't allow showing a section at zeroth position which doesn't have any row.

Hi,

In the method forwardInvocation, you assume that my class had implemented 'numberOfSectionsInTableView:' which is not mandatory.
If the method is not defined, you have to assume 1.

Regards,
Marce.

-(void)forwardInvocation:(NSInvocation *)invocation {
if (!_proxyObject) {
[self doesNotRecognizeSelector: [invocation selector]];
}
[invocation invokeWithTarget:_proxyObject];
}

(lldb) po invocation
<NSInvocation: 0x16d51f10>
return value: {i} 0
target: {@} 0x1eb8e0c0
selector: {:} numberOfSectionsInTableView:
argument 2: {@} 0x173a0a00

Hi,

I like your implementation but I found a big problem.

I found a retain cycle with your DND table, this methods retain my object (the delegate) and it produce a retain cycle. They shouldn't.

-(void)setDataSource:(id)dataSource and
-(void)setDelegate:(id)delegate

When the owner of my object releases it, my object doesn't die.
I had to call a method which I called willDealloc, in order to put this code and break the cycle.

_tableView.dataSource = nil;
_tableView.delegate = nil;

Regards,
Marce.

PD: If the table has more than one section, moving a cell through sections, produce a crash.
PD: My project is non-ARC.

Hi,

Thanks for the great library. I recently came across an issue while testing ios9 in my app where reloadData no longer works after asynchronously fetching data from my server (my datasource methods are not called) - you can read more details here https://forums.developer.apple.com/message/41228#41228.

I don't think it has anything to do with DragAndDropTableView but I thought I would check if you'd tried it on ios9 and whether you had run into any issues.

Thanks!
-Patrick

Not sure if what I wrote in the headline is the cause but this is the symptom.

When the UItableView is empty, and I insertRowsAtIndexPaths I get the following crash:

*** Assertion failure in -[DragAndDropTableView _endCellAnimationsWithContext:], /SourceCache/UIKit_Sim/UIKit-3347.44/UITableView.m:1623

I switched back to regular UITableView (to see if DragAndDrop is the problem) - it works :( so it's definitely something with DragAndDrop...

The code:

    ChapterDataItem *item = [[ChapterDataItem alloc] init];
    item.type = @"text";
        dispatch_async(dispatch_get_main_queue(), ^{
            [chaptersArray addObject:item]; //add object should be on the same thread for consistency of the data
            NSIndexPath *newIndexPath = [NSIndexPath indexPathForRow:[chaptersArray count]-1 inSection:0];
            [self.tableView insertRowsAtIndexPaths:[NSArray arrayWithObject:newIndexPath] withRowAnimation:UITableViewRowAnimationFade];
        });

The number of rows returns the correct number of cells (nothing fishy here)

- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
{
    if (section == 0)
    {
        return [chaptersArray count];
    }
}

Any help will be appreciated...

First of all - Awesome package. Thanks a lot!

I have section 0 that allows reordering of cells. Section 1 - doesn't allow.
The thing is when the user drags a cell "too low" (his intention is to set it the last cell in section 0 but he "misses")
I get a crash:

*** Assertion failure in -[DragAndDropTableView _endCellAnimationsWithContext:], /SourceCache/UIKit_Sim/UIKit-3347.44/UITableView.m:1623
2015-06-09 09:44:52.725 Cookila copy[23234:619162] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of rows in section 0.  The number of rows contained in an existing section after the update (2) must be equal to the number of rows contained in that section before the update (2), plus or minus the number of rows inserted or deleted from that section (0 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 1 moved out).'

How can I avoid it without getting all the sections in the swap game