greybax / awesome-it-films Goto Github PK

Just for example https://weichiachang.github.io/awesome-singer-official-portal/

After renaming project it-films -> awesome-it-films some of live demo links have became broken.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

see issue #67

Big collection can be found here: https://shields.io
P.S. Please if you send PR just add link to this issue for relation.

Hey @greybax, I saw that in dark mode on the website and in the GitHub README, you can see white edges in the logo which doesn't look good

• On the website
  

• In the README
  

This is even more visible when the image is zoomed in

I have made a pull request that fixes the image: #126

• No more white edges!

any suggestions are welcome! 👍

Project becomes complex and would be nice to introduce any test framework and write couple tests.

A good story should not be limited due to language barriers. Maybe we can add movies from other spoken languages with links to sub-titles for those movies so anyone could watch it.

Just a suggestion. Keep up the good work! 😃

more info in issue #67

Check and refactor project structure before resolving the issue

Generate storage.js from _prebuilt.md - The user is going to add the IMDb link when adding a movie. We could simply parse the file and add this into storage.js

From issue #67

Person with laptop should has white color

Now in UI https://greybax.github.com/IT-films we have only 3 categories:

• movies
• documentary
• tv-series

Also would be nice to have some specific filters for each category such as year and country. It could be done because we already have this data for each movie.

Would be nice to have a cool logo for our project. Will appreciate any ideas and designs! 🎨

Please add a link in your PR to this issue.

Contributing template

Please use the following URL https://greybax.github.io/awesome-IT-films otherwise a 404 page is displayed:

Should be fixed on github repo and github pages

I have obtained the API key and I built the scripts as mentioned in CONTRIBUTING.md but when I run npm start, I get this error:
missing script: start.

I noticed that the start script has not been defined in the package.json file. I am sorry I am new to this and I believe there must be a reason behind this. What is the solution to this?

Please advise.

Need to investigate some way to keep movie ratings up-to-date automatically in accordance with IMDb?
Ex. https://github.com/worr/node-imdb-api

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Hard to find _prebuilt.md

From issue #67

With #63 we have automatic ratings, but this includes way more steps required to go through when you add a new movie.

My 2 cents:

• Generate storage.js from _prebuilt.md - The user is going to add the IMDb link when adding a movie. We could simply parse the file and add this into storage.js
• Make Contributing.md more understandable. I had to hunt for _prebuilt.md
• Then run npm run build-movies -> This is assuming that whoever is adding the movie knows how to use npm to install dependencies. Correct me if I'm wrong, but the user needs a local api-key?
• Use something like Travis CI to build instead. I'm thinking of a pipeline like this: User modifies prebuilt.md and sends PR > Accept PR > CI automatically generates storage.js from _prebuilt.md. Then it runs npm build-movies and deploys it back to branch.