Code Monkey home page Code Monkey logo

ghsidebarnav's People

Contributors

gresrun avatar jcoleman avatar soleares avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ghsidebarnav's Issues

Search result with variables

Hi
I have a question about the search menu.
I use a webservice to get a JSON response witch is shown in the search result.
My problem is that I can get it to show the text but only that.
I have from JSON three variables/columns ( ID, Name, Function)
How can I pass all these to the Search result? I want to show the name, and i want to have the ID and Function as hidden variables and be able to use these variables when tapping one of the result cells....

Is this possible in some way?

How to use modal view controller?

Hello, is there way how to correctly use modal view?
For example when I want to present modal view in some content screen (selected by menu). View is presented correctly, but when is need to close modal view by dismissModalViewControllerAnimated it does not work.
View is closed but content view is reset to first controller.

Thanks a lot for any advice.
All best.

Problems with iOS 7

Hi.
Thank you for this project. I used it.

But in iOS 7 I found issue.

Step:

  1. Open menu.
  2. Click to search bar.
  3. Print there are symbols.
  4. Click Cancel button.
  5. Click to search bar. But searchDisplayController does not appear
    screenshot 2014 07 01 13 25 29

Search sometimes doesn't work

First thanks a lot for such a great library

My problem is when I tap on the search the searchdisplay appears with the cancel button and only the search table appears at that moment as normal, but if I canceled the search and tried again to do the same thing to search; the search doesn't work which means it doesn't fill the screen (no active) and as long enter any text nothing happens.

seems in GHSidebarSearchViewController.m the method

  • (void)searchDisplayControllerWillEndSearch:(UISearchDisplayController *)controller

deactivate the searchDisplay controller : [searchDisplayController setActive:NO];
and whenever we try to search again I guess it will stay inactive!

Thanks

Video Tutorial

Hello Greg,

please make a video tutorial who can i add this GHSidebarNav to a existing project it is difficult for me as beginner :(

SideBarNav wont disappear when clicking a search result

Hi.
I have tried many ways of doing this, but when i get a search result from JSON and then clicking one of the rows, i get the right view in the view controller, but the sidebar menu does not hide.
I then have to click cancel to get to the viewcontroller.
Here is my code:

- (void)searchResult:(id)result selectedAtIndexPath:(NSIndexPath *)indexPath {
    NSDictionary *rowDict = (NSDictionary *)result;
    NSLog (@"Selected %@", rowDict);
    RevealBlock revealBlock = ^{
        [self.revealController toggleSidebar:!self.revealController.sidebarShowing
                                    duration:kGHRevealSidebarDefaultAnimationDuration];
    };
    // NOTE: I see that you were trying to pass in a URL into the title.
    // I'm assuming that was because you wanted that information available to the view controller so it could load it or something.
    // You should create a view controller for your own needs and have an NSURL property on that view controller for that purpose.
    // E.g.: NSURL *wallURL = [NSURL URLWithString:[NSString stringWithFormat:@"%@/UserWall.aspx?id=%@&Uid=%@", YourDomainPrefix, rowDict[@"ID"], UniqueID]];
    UIViewController *rootVC = [[GHRootViewController alloc] initWithURL:[NSString stringWithFormat:@"/UserWall.aspx?id=%@&Uid=%@", rowDict[@"ID"],UniqueID] initWithTitle:[NSString stringWithFormat:@"%@", rowDict[@"Name"]] withRevealBlock:revealBlock];

    UINavigationController *navController = [[UINavigationController alloc] initWithRootViewController:rootVC];
    UIPanGestureRecognizer *panGesture = [[UIPanGestureRecognizer alloc] initWithTarget:self.revealController
                                                                                 action:@selector(dragContentView:)];
    panGesture.cancelsTouchesInView = YES;
    [navController.navigationBar addGestureRecognizer:panGesture];
    self.revealController.contentViewController = navController;
    [self.revealController toggleSidebar:NO duration:kGHRevealSidebarDefaultAnimationDuration];
}

Storyboards

Hey,

I noticed that you have a storyboard enabled branch, I was wondering if this is under active development/up to date or whether it was just a one of experiment?

Is it likely that this will be merged into master at all?

Trying to determine the best offering out of all of the 'SlideMenu' type implementations out there, and this looks to be one of the nicer ones, though would like the ability to use storyboards.

Cheers

Strange Navigation Bar behavior with transitionFromViewController

In actual configuration it's barely perceptive, but the glitch is there. It's possible to reproduce this bug with more detail by adding an animation to self transitionFromViewController: on method setContentViewController of GHRevealViewController.m. Also, enabling slow animations on iOS Simulator will do it too.

searchResult behavior

Hi Greg,

Thank you for your nicely library ;)

However i have a problem with the search result behavior. I would like to push detailViewController when someone select a row but there is not navigationController so it is not possible.

I found a solution but it is not the best way. Using [self presentViewController: animated: completion:]; on this delegate - (void)searchResult:(id)result selectedAtIndexPath:(NSIndexPath *)indexPath;

i would love to see the same behavior when you present a GHRootViewController on the GHMenuViewController. I tried to do it but i had strange bug.

Do you have something in your mind ?

Antoine

Open/Close SidebarNav Swiping

How can we do this action by swiping the screen to the left for hiding and to the right to showing?

Thanks, you made a good job!

Reload View

Hi
In my app Im using the sidebar menu to open a viewcontroller with a webview.
I'm passing the URL on click.
But if i follow a link inside the webview, and then click on a menuline in the sidebar, it just opens the same (last) page in the webview....
How can I force the webview back to the original URL when clicking the sidebar?
Or just reload the viewcontroller?

Pan gesture not working correctly in iOS7

First of all this is a great library and i'm using it in my app. I have added pan gesture recognizer on my view controller and connected it to the revealSideBar method (Plz correct me if i'm doing it wrong). Gesture is working but with a lot of flickering while dragging the side navigation bar over my view controller. Plz Help.

UIStoryboardEmbedSegueTemplate

Hi, I'm getting an error when i run the GHSidebarNav storyboard's project on my xcode with iOS 5.0 and 5.1 on device and simulator.
Looks like this:

*** Terminating app due to uncaught exception 'NSInvalidUnarchiveOperationException', reason: 'Could not instantiate class named UIStoryboardEmbedSegueTemplate'

How can i fix using storyboards.

Greetings

Navigation button outside the sidebar

Im trying to have a button on a viewcontroller that will have the same behaviour as if I would tap in the navigation sidebar button, so let say you have a navigation item Messages and you have a button in your viewcontroller also Messages how can you get it working ? I tried to use "presentViewController" but than the (IBAction)revealSidebar button doesnt work :( can anyone help me with this issu I'm using the storyboard version.

Thank you guys for your help.

Refreshing GHSideBarNav

Hi,
I'm using your GHSideBarNav, and it's working great.

But I do have one issue.
Is there a way to update the contents of the sidebar,
after the initial "init"?

Please add semantic version tags

Hi,

I’ve recently added GHSidebarNav to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OSX and iOS Xcode projects and provides a central repository for iOS/OSX libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, GHSidebarNav doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags

Autoresizing Mask of Sidebar Controller

Would you be open to a PR that added a line to configure the sidebar controller's view's autoresizingMask to be UIViewAutoresizingFlexibleHeight? It currently sets the view frame, but if the mask isn't correct that frame can get messed up pretty easily (particularly on an orientation change.)

It would seem like a reasonable default, but wanted to run it by you first.

Anyway to disable pan gesture sometimes?

I found if I have a navigation controller which has a wizard like a few steps, user swipe to navigation bar and reveal the side menu can be confusing. If there anyway to disable that, and make user can reveal side menu only at root view controller only?

Thanks.

How to get back to the root view controller of other menu item

menu 1, menu 2 each of them represents a UINavigationController (same as the example),

[menu 1] --> root view controller
[menu 2] --> root view controller --> VC2 --> VC3 --> VC4

I want to have a button in VC4, after tapped, goes to root view controller of [menu 1]. I tried several approaches, none did as I wanted.

How can this be used to present a modal view controller, or an action sheet?

I can see from the previous issues and comments that this controller can be used to present a modal view controller; I have tried to do this in the code to no avail. Can you possibly provide some same code either in the github project, or in response to this issue, to show 1) how to present a modal view controller and 2) how to present a UIActionSheet? I am also trying to figure out how to present an email composition, but hopefully I can figure that out from any other code you can provide. The idea of reveal blocks is new to me.

Rotation Support

Hey,

awesome project! I appreciate the your storyboard version.

I recognized a small bug. When the search view is showing and you rotate the view, the search view doesnt resize properly.

So I made some modifications:

  1. Adding a BOOL to Reveal View Controller

    @property BOOL searchIsShowing;
    
  2. Modifying toggle search view function to deal with new BOOL

if (!showSearch) {
        self.contentView.frame = CGRectOffset(self.view.bounds, CGRectGetWidth(self.view.bounds), 0.0f);
        [self.view addSubview:self.contentView];
        [self setSearchIsShowing:NO];
    } else {
        [self setSearchIsShowing:YES];
    }
  1. Adding rotation delegate
- (void)willAnimateRotationToInterfaceOrientation:(UIInterfaceOrientation)toInterfaceOrientation duration:(NSTimeInterval)duration
{
    NSLog(@"Content View Frame: %@", NSStringFromCGRect(self.sidebarView.frame));

    if (self.searchIsShowing)
        [self.sidebarView setFrame:self.view.bounds];
}

cheers.

hidden keyboard when open menu

hello thank for amazing framework

i have problem, when use textfield in view and keyboard rise up and go to menu... the keyboard doesnt hidden... and its still appear

check image attached

iOS Simulator Screen shot Mar 19 2013 8 23 03 AM

Modalviewcontroller are not working

On the Sidebar i select for example menupoint 3 which brings up the 3rd ViewController.
In this VC I present a ModalViewController. After dismissing this MVC the wrong ViewController appears. If I check the Sidebar: Instead of number 3 now there is number 1 selected.

EDIT: DOH! Did not see the ViewVillAppear Method in the GHMenuController. Sorry, closed.

Search Scope not removing on didSelectRow

If you include scope on the search bar and then populate the list, the scope bar will not go away on when you select menu items other than the first one.

I see now that your storyboard version behaves correctly, so I will go over that code to see what the differences are.
BTW: great project

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.