greird / chordictionaryjs Goto Github PK

x32030 is not recognized as a Cadd9 chord.
When generating a Cadd9 chord, the tab returned is x32020, which is wrong (it would be a Cadd9min).

For instance, getChordsList cannot generate a maj9 chord for the moment, as the integer formula has a non-readable format.
{formula:"1-3-5-7-9", integer:"0471114", name:"Major ninth", suffix:"maj9"}

Possible fix: Adding a separator between each integer "0-4-7-11-14".

Test with x912160x and a 7 frets layout.

Chords are sometimes cropped, eventhough there should be enough frets displayed to show the chord correctly.

For instance:
Tab: 258xxx, Fret number: 7
Enough frets but one note remains out of sight.

Function getChordLayout accepts A standard tab notation, as a string with no blank space. Can contains any number or the letter 'x'.. That means, double-digits there are treated as single-digits and it is impossible to generate those. Can be sorted by optional separator like comma, semicolon or the mentioned space.

Combination of these two criteria prevents some bar chords to be tagged :
chordAnatomy.rootIsLowestNote && chordAnatomy.rootOnLowestFret (e.g. A)

chordAnatomy.rootIsLowestNote prevent a standard D chord to be tagged

xx1091010 or x1212121312 are not recognized as C6/9 chords.
However, it recognizes the right notes xADGCE.

When generating a C6/9 chord, it generate the following tab : x32223 with the following notes xCEAC#G. This is wrong. C# should be replaced with a D.

Expected: "1-b3-b5-b7"
Result: "1-b3-5-b7"

Misinterpretation of diminished 5 ?

Tested with:

• Cm6/Am7b5 (xx5545)
• D#m6/Cm7b5 (8988xx)

Ex: x3243x (Cmaj9) doesn't match any formula.