gregparkes / battlesimulator Goto Github PK

Hello, I think I found an issue: every sim I run has the same problem including the example notebooks and dataset. In the very first frame of the simulation there is one and sometimes two units on one of the teams that are not displayed as arrows but as hexagons. From what I can tell these units have no dxx/dxy movement and remain stationary.

All units in the battle, including their own team target these stationary units first; they also target themselves in the initial step of the simulation which is very odd.

It seems like it always occurs with units on the first team/army that is created.

I can't find what the problem might be, here is a screenshot of the first frame of the examples/notebook1 simulation using the clone wars unit dataset.

Here is the output from the first frame: all of team 1 is targeting unit 2 with the exception of unit 4 which for some reason is targeting another teammate.

I am interested in seeing the number of kills each unit and team achieve in the battle. It seems like keeping the running total in M might work. The unit level totals would be available in the last frame of the simulation which you can get by running with return_frames = True.

In the return_frames = False scenario I suppose a more robust results dataset would need to be implemented which in addition to returning the remaining units for each team it would also include the number of kills each team achieved. If this were to be done a pandas dataframe with the teams on the rows and statistics in the columns seems ideal. Other stats could also be added like total damage done, team level accuracy, units lost, types of units killed, etc.

Obviously this is not a trivial enhancement but wanted to note it here.

I am trying to run a k simulations with more than two teams and am receiving this error:

ValueError: Shape of passed values is (30, 2), indices imply (30, 3)

I tracked it down to this line in _battle.simulate_k

runs = np.zeros((k, 2), dtype=np.int64)

it is assuming the results have only two teams. I think a quick fix is to change to the below which is the number of teams:

runs = np.zeros((k, np.unique(self._teams).shape[0]), dtype=np.int64)

the team_counts results returned by simulate_battle contain a records for each unique team in M.

This appears to work for up to 30+ teams/allegiances

HI Greg!
Thanks for this awesome battlesim!
I'm trying to implement it on my pc to use it in my D&D Campaigns, cause I find it awesome.

I'm following the tutorial and the error that is given when I run "battle.sim_jupyter()" is "name '_simplot' is not defined".

Is it a problem in a package?

Thank you!

In examples/notebook2 I am receiving an error after changing Magmaguard team to a third team name in the starwars-cloneswars.csv dataset.

The issue appears to be due to the battle now containing 3 teams after loading the unit dataset file, but the simulate_battle is only returning a result for the unique teams in M.

Generically: this error happens when the number of unique teams loaded into the battle object is different than the number of teams that are added via create_armies

Solution: I suppose you can just make sure to add armies for all of the teams that are loaded into the battle object.

I found this when playing around with examples/notebook2 which loads a number of units from the csv dataset file but only runs a sim using two unit types which are in three army groups, and represent only two of the three unique teams in the dataset file (after I changed the Magmaguard to a third team name).