greg-ses / simpleui Goto Github PK

Only works if there is a single overlay. Will most likely need to rethink the logic

Issue to track a collection of improvements to be handled as a single issue for the sake of efficiency.

• Issue 1. Fix branding in "Parameters" bundled sub-app.
• Issue 2. Fix performance problems on Overlay pages - possibly related to gifs
  I have observed that there are significant resource leaks on the Overlay pages.
  • Note: Investigation is in progress
• Issue 3. Update to most recent version of Angular.
  • Note: In Progress - doing in conjunction with Issue 2.
• Issue 4. Perform npm audit fix and related fixes to address all security issues flagged during npm install and npm run build
• Issue 5. Add a uimanager.html page that can be used to do control relaunches of "managed" simple_ui pages. This is useful as a work-around for pages that have resource leaks.
  • Note: Partially implemented
  • A working prototype is installed at /purification/html/uimanager.html

Original ticket: Gitlab

Add a popup to show the status of the individual ZMQ sockets (connected, connecting, disconnected)

I only added this because I saw that the apache server would get this signal before shutting down. This signal shouldn't be treated as fatal. After further research it turns out that apache miss uses this signal on purpose .

• Create a few unit tests
• Create some integration tests
• Create some end-to-end tests
• Document how to run the tests in WebStorm and from Bash
• Implement a build runner that runs the tests

Setting ignore_errors: true on the archival of the previous deployment risks breaking the existing deployment if the current deployment fails.

Would be preferable to configure a "force" flag with a default of "false" for ignore_errors.

Need to figure out link-related errors which may occur which can lead to errors and inability to deploy an update.

Check if the native ZMQ lib is required for node to use zeromq.js befoer removing these

Toms change from localhost->svcmachineapps need to be added to the deployment of the apache re-writes.

We have a bunch of PHP files saved from when we transitioned to angular. Remove these since they are no longer needed

For future work, we need to get the company specific stuff out of the open source project.

Originally posted by @tompatman in #20 (comment)

1. Allow building from the GUI to copy its output to the same deployment folder that build-all-native.sh and build-base-web-packages.sh use. Currently it's confusing to make changes in the GUI and do a build, but not have the build show on when deployed to a prototype or production system. Addition of copy-dist-to-output build script and update to build steps in README.md help fill this gap.
2. Fix broken mock request in simpleui-server to allow testing with data that hasn't yet been implemented in the back-end.
3. Add test mock data queries for purification (Dashboard and Purification tabs).
4. Improve documentation.

Need roles such as these:

1. "administrator-level-control" - can view and change all options
2. "support-level-control" - can view and change options related to a support-level change, such as replacing a VEC or a pump, or changing a calibration. (Is this really different than "administrator-level-control"?)
3. "readonly-customer" - a "customer" user who has full access to "customer-level" information
4. "readonly-partner" - a 3rd-party allowed to view information with "partner-level" information
5. "readonly-public-viewer" - a 3rd-party potentially viewing over the internet who is allowed to see only non-proprietary information that is also directly allowed by the customer.

Currently, if the recent event tables are off the screen, you cannot scroll horizontally to see it

https://bojnansky.com/running-angular-tests-with-github-actions/

• build on save, etc

The overlay pages have significant memory and resource leaks and excessive CPU consumption.

• Research and correct memory leaks.
• Examine if there's an issue with animated gifs and refactor into css classes (or other) if there's a problem.
• Unwind obsolete drag and drop features.
• Move transformations that can be made in advance from client-side javascript in base_app into simpleui-server.

Clean up readme and remove old / outdated stuff

TSLint is depreciated and it is recommended to use ESLint

npm WARN deprecated [email protected]: TSLint has been deprecated in favor of ESLint. Please see https://github.com/palantir/tslint/issues/4534 for more information.

Steps to reproduce:

1. Build and deploy bms and bmsui
2. Browse to http://your-sim-name/bms/
3. Start the browser debugger with CTRL-SHIFT-I
4. Click the Fault React button

Problems:

1. Notice that the browser debugger console gets a javascript error after Fault React is clicked.
   
2. Notice that there's no way to enter the integer:
   

make sure popups still work and remove dead popup-dialog code

Remove unused parts of the build steps (EX: node-dirs-to-copy.txt) and figure out if we can simply it at all

The following issues which are seen during npm install (right-click on base_app/package.json)

found 156 vulnerabilities (1 low, 51 moderate, 100 high, 4 critical)
  run `npm audit fix` to fix them, or `npm audit` for details