Code Monkey home page Code Monkey logo

cantherm_old's People

Contributors

cfgold avatar gmagoon avatar jwallen avatar mrharper avatar rwest avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

cantherm_old's Issues

Physical constants and conversion factors could be refined

Some of the physical constants and conversion factors seem to be off from the values I am familiar with by a fraction of a percent. I have already adjusted R (universal gas constant) in the following edit: http://github.com/gmagoon/CanTherm/commit/2a657aea4882337e1c54c8fcf059b32e303afce4 , but various other values could be refined as well. Other examples include:
4180 and 4.18 should be 4184 and 4.184 (J/cal)
6.023e23 should be 6.022...e23 (Avogadro's number)
1.6605e-27 is used sometimes whereas 1.67e-27 is used elsewhere (amu to kg?)

Calculations slow

CanTherm completes calculations in a matter of seconds, but I think there is potential for it to be done a lot faster. I'm guessing the limiting step is the diagonalization of the Hamiltonian matrix to get energy eigenvalues. Perhaps we could speed this up through cythonizing the code?

Chirality not taken into account

CanTherm doesn't easily allow to account for changes in chirality (mirror symmetry) between reactants and TS which can cause errors of a factor of two in the computed rate constant. It could also contribute to entropy (S) being off by a factor of R*ln(2).
I think this may be addressed (in a somewhat hackish manner) in the version of CanTherm that I use as a submodule with RMG-Java.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.