greencore / icecat Goto Github PK

I found a product that don't have any image so this line fails

Cannot read property 'map' of undefined

  <ProductGallery/>

Module not found: Error: Can't resolve 'https' in 'C:\Documents\basicapp\node_modules\icecat\lib\OpenCatalog'

Would this be an issue on my end? Https nodemodule is installed and nothing else has issues finding this. Is there anything you can advise?

Cheers, Tom.

method getProductManualPDFurl returns "PDFURL" instead of "ManualPDFURL"

<ProductDescription ID="48068167" LongDesc="<b>Stylish 40” screen with 4K resolution and USB hub</b>\n\nThe ProLite ........" ManualPDFSize="3332489" ManualPDFURL="http://pdfs.icecat.biz/pdf/48068167-5566-manual.pdf" PDFSize="285343" PDFURL="http://pdfs.icecat.biz/pdf/48068167-5427.pdf" ShortDesc="39.5 MVA, 3 ms, 350 cd/m², 3840 x 2160, 16:9, PiP, PbP, HTCP, VESA, OSD, 3 x USB 3.0, HDMI, VGA, Black" URL="http://www.iiyama.com/gl_en/products/prolite-x4071uhsu-b1/" WarrantyInfo="" langid="1"/>

should be

const mObjectSet = {}

just want to be sure :P @GreenCore

Currently, we're (recently) targeting >=6.

Is this really necessary? I think we could support lower, say >=4 for xml2js?

Cannot read property 'length' of undefined at icecat.getImages (icecat/lib/OpenCatalog/product.js:193:40)

if (!this.productData.ProductGallery.length || !this.productData.ProductGallery[0].ProductPicture.length)
isn't safe if ProductGallery is undefined.

Create test version of icecat api

Any toughts on adding all properties from the xml response?

For example:
EndOfLifeDate
ReasonToBuy array
BulletPoints array
Reviews array

Thanks in advance

I have fixed this in #3