To add to the legit serach feature, It would be nice to have a delay, to make it look a little less suspicious for twitchy server admins.

I'd suggest adding some randomness to the delay too just incase.

Add setting to choose what the second trade is. Paper to emeralds or emeralds to bookshelf

Enchantment Solution is a server mod that adds more enchants.

https://www.spigotmc.org/resources/enchantment-solution.59556/

The enchants show up as enchantmentsolution:, not minecraft:, and cannot be added in the current GUI.

The mod also makes all enchants appear on minecraft:book trades, not minecraft:enchanted_book, so they are not detected.

--- Perhaps make the item to look for enchants on, and the enchant names part of a config file, not pulled from MC.

idk i dont wanna get ac banned

This is an issue with my current todo list for this project. Priority top to bottom :)

• Timeout Option
• Configurable Delay
• Action Trade Found
• Sound on Trade Found
• Setting to lock the trade as soon its found
• Add setting to choose what the second trade is
• Show Selling Enchantment in front of villager
• Make trades go past their max level
• Accessibility (Narrator, Key Selection)

(Not every item marked as completed is committed instantly)

Nevermind this problem has been addressed by another user called stubbybird i think i'll check if the file u attached to them works for me If it doesnt i will edit this and make it normal again!

Hi! I've been trying to use this mod too get easy trades and whenever i use it on this sever i play on it never replaces the lectern or checks the villager trade. Is this because it doesnt support multiplayer severs i am playing on a paper sever so that might be why but if you could make it so it work on multiplayer severs that would be awesome!

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

itsmiir/tooltipsplus#19 all details here

when trying to select the price or level of the enchantment, i can click the textbox but cannot change it's content. Making it impossible to set the price or level

An option can be made to make the head movement from the lectern to the villager slower, so that it doesn't look so suspicious to the servers.

Make it so there a configurable piece of text telling the enchantment of the villager

In the config GUI there's an option to select a set of enchantments to search through. This method is set to stop/notify when a desired enchant is found, regardless of its cost in emeralds.
My request is to have a field in which we can stipulate how much the max price has to be for each of the items we select. The rationale behind this is that it would be way faster to find a suitable deal with the desired amount of ems if we can add the max it the list as well.

It's known, in vanilla, that the price in emeralds depends on the enchantment level and "treasure" (Mending, Frost Walker) status. The list always goes for the enchantment level, ignoring the cost in emeralds, so according to this premise:

• 5–19 for Lvl I,
• 8–32 for Lvl II,
• 11–45 for Lvl III
• 14–58 for Lvl IV
• 17–64 (capped) for Lvl V
• Double price for any 'treasure enchantment', so Mending/Frost Walker will cost 10–38 ems and Frost Walker II will be 16–64

Is it doable?

Thanks.-

Crashes when opening config.

crash-2023-10-14_20.38.35-client.txt

Is your feature request related to a problem? Please describe.
I am using a plugin called enchant squared and it has many new enchants but the mod wont detect them

Describe the solution you'd like
Add support for custom enchants or a way that we can add more enchants to the list by our self.

the mod is amazing and withe the new mc 1.21 comes some new enchants so please can you update

Hi, can u make a new version or a "port" of this https://github.com/Ivan-1F/VillagerHelper?tab=readme-ov-file

i think is useful in your mod,

If the axe gets really low while searching for an enchantment, the process will be stopped and you will be notified...

The search gets stuck on the first or second attempt, because it seems it's trying to check the villager much too soon, before it can get the job:
https://user-images.githubusercontent.com/16958149/216428904-ef8fb99f-a231-45ad-ae08-47bc9b0c2d5c.mp4

Maybe at re-attempts to read the villager's trades, or a configurable delay for it.

Otherwise, great job, thanks for your work 😄

When a trade is found a sound effect is played (could be turned on and off in the config menu). Could be the advancements sound or smoothing else idk. Could be cool

tptovillager is toggled off but moves

here's the video

https://www.youtube.com/watch?v=OaeCzh9KRJo

i'm using ver.1.2.3

When I use the mod i need atleast 4 lecturns so that IT works but wenn I play suriviel i offen don't have more than 1.
So mabey you could make It so It works with only 1 or 2.

While cycling through the trades, can the name of the trade available show on the screen as part of the "Checking trade --- attempt: ##" message.

While this is cosmetic, it would be interesting to see what is being offered as you watch it cycle through.

Ich werde jedesmal aus meiner Singleplayer Welt gekickt, wenn ich die Suche starte. Es scheint egal zu sein, nach welchem Entchantment/welchem Preis ich suche. (1.20.1 fabric mit einer Reihe anderer Mods)
Auf dem Screen steht dann:

Connection Lost
Internal Exception: java.lang.NullPointerEception: Cannot invoke "de.greenman999.config.TradeFinderConfig$EnchantmentOption.getMaxPrice()" because "enchantmentOption" is null

Im Log steht übrigens nichts. Lediglich, dass die Welt gespeichert und beendet wird.

I'm getting kicked from my singleplayer world when starting the search for sharpness V.
I tried with other enchantments and prices and the same thing happens. I'm playing in 1.20.1 with a few fabric mods.

It says

Connection Lost
Internal Exception: java.lang.NullPointerEception: Cannot invoke "de.greenman999.config.TradeFinderConfig$EnchantmentOption.getMaxPrice()" because "enchantmentOption" is null

There's nothing to see in the log.

It would be cool if you could Input the name of a modded enchantment and serch for it as well.

wen??

I have mods that let the enchants go passed their max levels, and up to 255. The GUI caps the enchant levels to their vanilla max

You set a maximum to the integers however this makes putting the right values in (if even possible) extremely hard at least if you accept multiple different trades.

You just cant modify max values pretty much. for example if you set 24 as value you cant delete either number as you would be below minimum cost even if you want to go to 40 or something

I would like a setting that as soon as the trade was found the immediately locks it, if you go during the search afk and does not pay attention to it, then it changes again.

allow to send chat message or disconnect on enchant found

It would be cool to press a keybind and then it opens a gui and there you can select the enchantment you want...

when I change the $ amount nothing happens, someone pls help?

when will there be a version for 1.19.4? it just looks like today's version doesn't work...

For example:

/tradefinder search minecraft:sharpness 30
/tradefinder search minecraft:unbreaking 20
/tradefinder search minecraft:power 25
/tradefinder search minecraft:protection 20

Will find any on this inputs.

Please migrate the trade finder mod to version 1.21

when the villager hasn't converted it just puts the lectern back

While looking for a specific trade, you cycle through hundreds in not thousands of unwanted trades. Can the mod have a feature to capture these in an simple .csv file stored locally somewhere in the .minecraft folder (maybe the config folder?) so at a later date that information can be used.

The issue:
Sometimes when breaking and placing a lecturn, the villager will ignore the lecturn until it is broken and placed again,

The solution:
I propose a timeout, so if the villager takes longer than a configurable amount of time (e.g. 10 seconds) then it stops attempting to check the trade, and continues into breaking mode.

Alternative solutions:
Manually breaking and placing the lecturn again works, but it means I can't be AFK at the villager, because this happens around once every 5 times a lecturn is placed. I am making a trading hall with every villager obtainable enchantment, so I would prefer a faster way.

Additional context
This seems to only be an issue on my server, which is a PaperMC server, I haven't checked other servers, but it works fine in singleplayer
It also seems that they don't accept the profession at some times of day? I'm not sure if that's a paper issue too though because I can't get that to happen in singleplayer.

is there a 1.20 release date? It would be an amazing mod to have rn lmao. thx

Player does not swing left arm when placing lectern. The mod works fine, but it looks awkward. Could you please fix it? Thank you for developing a great mod.

Hello. I'm currently playing on a server where Enchantment Efficiency has additional levels. These books appear in auctions from residents. There is a limit to vanilla levels in fashion. I haven't figured out how to get around this limit, so I'm writing here.

Maybe it has already been implemented, maybe not, so I sent it as an idea.

When i do /tradefinder config my game crashes and when i do /tradefinder search i get kicked then when i rejoin im stuck looking at the villager

• Minecraft Version: 1.20.6
• Fabric Loader Version: idk but im using lunar client
• Fabric API Version [1.20.6] Fabric API 0.100.8+1.20.6
• Mod Version 2.1.1

mod is not working i tried 1.20.2 too but it was crashing my game and 1.20.1 is not working tell me how i can fix it plzz

I understand, you have made Librarian Finder Mod for newer versions. But there are few servers and players who play in older mods. So it would be awesome if you made a 1.16.x version.

Add UI to select enchantments, level and price for each enchantment.

Describe the bug
As Title Say,you can't do searching when Villager has name from nametag

To Reproduce
Steps to reproduce the behavior:

1. Make your searching room
2. Name one of your villager with any name with nametag
3. start searching
4. fail

Versions (please complete the following information):

• Minecraft Version: [1.20.4]
• Fabric Loader Version [ 0.15.10]
• Fabric API Version [0.97.0]
• Mod Version [2.1.1]

Can't change values for cost or level in gui
version 2.01

It would be awesome if there was support with Trade Cycling. You would select a villager as you normally do then it would open the gui and cycle the trades until it found the trade you submitted.

Also, I think that it would be nice to have the min/max trade price listed when type in the command. So Thorns III for example would show something like "price: 11-45".