great-northern-diver / ggmulti Goto Github PK

Hi

We are preparing the next release of ggplot2 and our tests show that ggmulti fails with the new version. Since you are doing some very unsafe overwriting of different internal ggplot2 functions it is difficult to say exactly where the issue is located.

I urge you to reconsider your current approach since it has the potential to break again and again, while also potentially break other packages in hard-to-debug ways because you are changing ggplot2 functionality that other packages depends on

we are planning to release the next version of ggplot2 on May 31st

best
Thomas

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that your package somehow includes references to ggplot2 code from when it was build, either by reloading saved plot objects or by grabbing functions at build time. Please see https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/ for some more info about why this can cause issues.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/[email protected]') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards
Thomas