Code Monkey home page Code Monkey logo

Comments (4)

dan93-93 avatar dan93-93 commented on June 5, 2024

Okay, in the end targeting the parameters worked:

            var options = new VoyagerOptions()
            {
                GraphQLEndPoint = isLocalEnv ? "/" : "/myapp/graphql/"
            };
            app.UseGraphQLVoyager(options: options, path: "/voyager");

So the problem is the original code wasn't hitting the overload. Is that an intended implementation going forward?

from server.

Shane32 avatar Shane32 commented on June 5, 2024

Yes; we switched the order of the parameters; path then options instead of options then path. The migration notes for that change are here:

https://github.com/graphql-dotnet/server/blob/master/docs/migration/migration7.md#migration-of-ui-middleware

from server.

Shane32 avatar Shane32 commented on June 5, 2024

I can't see that release notes were updated for this options block

The 7.0.0 release notes contains a link to the migration notes for v7.

https://github.com/graphql-dotnet/server/releases/tag/7.0.0

The bottom of the "description" section of the readme also contains the link to the migration notes.

https://github.com/graphql-dotnet/server#description

Please comment if you feel that the migration notes were difficult to find, and where you think the link should be placed.

from server.

Shane32 avatar Shane32 commented on June 5, 2024

Just FYI, the order of parameters was swapped to be uniform with UseGraphQL and other similar ASP.NET extension methods.

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.