Create GitHub release from AppVeyor on build success.

Docs: https://www.appveyor.com/docs/how-to/git-push/

Just want to share what I found https://github.com/APIs-guru/graphql-voyager
Maybe someone interested adding this to GraphQL.UI namespace 😁

We noticed that the WebSockets middleware would stop responding (and enter an endless loop of errors) if a client closed its connection.

It looks like the problem is here. Unless I'm mistaken, the loop should abort if completed, canceled, or closed, so each || should be &&.

I saw in this comment how to implement authentication. That's more or less working, but how do I implement authorization (determining whether a user is actually authorized for a particular subscription)?

For my HTTP requests, my controller code sets the GraphQL UserContext with user information that my Query and Mutation objects can then use. (I'm using my own controller code instead of GraphQL .NET Server's HTTP middleware.) However, for WebSockets, I don't see any way for a IOperationMessageListener to access or set a context for the Query/Mutation/Subscription objects to use.

Ideas or suggestions?

Thanks!

Now that 3.0.0 is out. Would it be possible to publish it to nuget?

Import current codebase from my private repo into this one

• public const string GQL_CONNECTION_INIT = "connection_init"; // Client -> Server
• public const string GQL_CONNECTION_ACK = "connection_ack"; // Server -> Client
• public const string GQL_CONNECTION_ERROR = "connection_error"; // Server -> Client
• public const string GQL_CONNECTION_KEEP_ALIVE = "ka"; // Server -> Client
• public const string GQL_CONNECTION_TERMINATE = "connection_terminate"; // Client -> Server
• public const string GQL_START = "start"; // Client -> Server
• public const string GQL_DATA = "data"; // Server -> Client
• public const string GQL_ERROR = "error"; // Server -> Client
• public const string GQL_COMPLETE = "complete"; // Server -> Client
• public const string GQL_STOP = "stop"; // Client -> Server

Get requests cause a null-ref exception when using GraphQL Http middleware.
I think adding a check for the request method would be enough to fix it.

https://github.com/graphql-dotnet/server/blob/master/src/AspNetCore/GraphQLHttpMiddleware.cs#L50-L53

Good job on the lib btw. Just started using it, very easy and intuitive.

Hi @pekkah,

Are you actively working on this?

Thanks!

According to the Apollo web socket transport implementation, a websocket is suppose to be able to handle Queries and Mutation in addition to Subscriptions. I was playing around with attempting to send a mutation over the websocket channel but the response back from this is always a GQL_ERROR package with the payload of both the data and the errors being null, which makes it very difficult to track down where the error actually occurs.

Problem:
Data for stopped subscriptions continues to flow to the Client.

Version:
Master branch

How to reproduce:
We are using the Apollo client with React, and the faulty behavior occurs when we unmount and remount components that subscribe to data. We attached an image that shows the issue in the Network Panel in Chrome

Suggested fix:
So far we have not debugged the codebase, but just wanted to raise the issue. You might immediately know what is going on. Let us know if you need help to further investigate this issue. We can provide a small test project that reproduces the problem.

It would be nice to have the package on NuGet so it's not required to add a custom package source.

@joemcbride how would I get the nugets published to the graphql-dotnet MyGet?

I setup AppVeyor for this project, all you'll need to do is add an appveyor.yml.

https://ci.appveyor.com/project/graphql-dotnet-ci/subscriptions-transport-ws

The middleware is not currently using the UseMiddleWare-api, which I think it should be.
This can be solved in the 'Startup.Configure'-function, the following way:

app.UseMiddleware<<ChainCompanySchema>>();

And next to that, having this function in the ITransport-interface (and inheriting classes):
async Task Invoke(HttpContext context)

I was getting the following error in most of the browser .

Chrome and opera allows to ignore but not in IE and Firefox . There is a possible fix given in the following URL .
Can I Provide a pull request for the same.

I think we should add logging using .NET Core Logging for the following:

• Queries
• Errors

Just following the install guide and there's a few things that may be outdated or I need help with.

• Looks like it's being released on the nuget gallery now, do we need the myget feed?
• Looks like dotnet add command requires the package specifier now. dotnet add package ...
• Looks like the UI (GraphiQL and Playground) aren't included in the nuget package. I couldn't use them as the setup suggested. Will they become available in this package or even a new one?

One question, will you be publishing it to nuget.org?

They just merged this, so I'm thinking we should use the same script link.
graphql-kit/graphql-voyager@7466fab

It would be nice to have an Apollo Link for client side using the new SignalR and have a transport compatible with that client.

As the solution name is now GraphQL.Server then the project names should match it

Currently using the Options to configure ExecutionOptions makes them singleton. Desired behavior is to create ExecutionOptions per handled query,mutation or subscription.

This is just a sneaking suspicion, but I'd loved to get a discussion going so I might be able to track down the errors I'm experiencing using this library.
When we saturate the Web Socket connection with a lot of outbound traffic we sometimes get this exception:

System.InvalidOperationException: TODO, RESX: net_Websockets_AlreadyOneOutstandingOperation;

This is although the wrong Exception Message, currently beeing fixed in dotnet core and is tracked in aspnet/WebSockets#207

The actual Exception Message is "There is already one outstanding 'SendAsync' call for this WebSocket instance. ReceiveAsync and SendAsync can be called simultaneously, but at most one outstanding operation for each of them is allowed at the same time."

When this happens the Web Socket connection is not torn down correctly, but still open between the Client and Server. But no data is no longer coming through as the server side WebSocket client is in a bad state.

As stated in the WebSocket SendAsync-method documentation https://msdn.microsoft.com/en-us/library/system.net.websockets.websocket.sendasync(v=vs.110).aspx
"This operation will not block. The returned Task object will complete after the data has been sent on the WebSocket. Exactly one send and one receive is supported on each WebSocket object in parallel."

So why would this happen?

I suspect the culprit might be in SubscriptionHandle.cs
public void OnNext(object value) { var json = _documentWriter.Write(value); _messageWriter.WriteMessageAsync(new OperationMessage { Id = Op.Id, Type = MessageTypes.GQL_DATA, Payload = JObject.Parse(json) }).GetAwaiter().GetResult(); } where I believe you shortcut the async nature of WriteMessageAsync by calling GetAwaiter().GetResult(), which would allow multiple outstanding operations at a time.

I would love to contribute a fix to this, but I am currently a bit stuck. So any insight would be appreciated.

Right now the userContext is built using the property public Func<HttpContext, object> BuildUserContext { get; set; } in GraphQLHttpOptions.

In order to request services you have to RequestServices property on the HttpContext in order to get the IServiceProvider. I would however recommend another approach a service was dependency injected into the GraphQLHttpMiddleware such that this service can use inversion of control.

I will submit a PR later for this issue.

Not really an issue, other than an issue of this being AWESOME.

Ran the sample, worked great. Kudos! 👍

@joemcbride could you set the default to develop?

Hey,

Would it be possible to add support for .Net framework. Currently this only supports .net core, thanks.

Currently managing the lifetime of the websocket connection is not handled "correctly". This should be improved.

Hi, any reason why you are choosing to target .NET Core? Why not target .NET Standard instead? That way it is also supported in .NET Framework

Hi, i have been working on integrating the GraphQL lib in AspNetCore https://github.com/deinok/graphql-server-aspnetcore

We are using this in production in our org and i think that it would be a great idea merge the two libs.
Taking the best of the two. For Example:

• My version have GraphiQL ready.
• Your version have a good Subscription support.
• Etc...

Also will be happy to help maintaining this library.

Allow providing UserContext for queries

When loading Playground through a https uri, I get the following errors:

Mixed Content: The page at 'https://<my graphql api playground>' was loaded over HTTPS, but requested an insecure resource 'http://<my graphql api>'. 
This request has been blocked; the content must be served over HTTPS.

I think the source can be found here:
https://github.com/graphql-dotnet/server/blob/master/src/Ui.Playground/Internal/playground.cshtml#L54
But I don't know how to make the check to see if the endpoint should be http or https.

https://github.com/graphcool/graphql-playground

Allow similar options to what UI GraphiQL allows

It seems alpha 3.0 requires GraphQL.Server.Transports.Subscriptions.Abstraction > 3.0.0 but their doesn't seem to be a nuget package for this?

Update readme instructions to match the current version. Before update see samples for example usage.

Currently looks like it just detects the right path (e.g. /graphql by default) and then assumes everything is in the request body. It should handle requests as recommended here: http://graphql.org/learn/serving-over-http/

I've done this in a my own implementation with a proper Controller, but will do a PR for this project shortly.

Hi,
In my case it's very easy to reproduce:

1. Start Server & WebApp and subscribe using Apollo graphql.
2. Refresh the page.

Server will start throwing:

'System.Net.WebSockets.WebSocketException' in System.Private.CoreLib.dll

Which even caught in the try/catch block doesn't properly close that connection but goes into infinite loop.

What helps:
Changing line 73:

to:

while (!source.Completion.IsCompleted && !source.Completion.IsCanceled && !source.Completion.IsFaulted && !this._socket.CloseStatus.HasValue)

From when I last used websockets, I believe the app.UseWebSockets() adds it using the "feature" collection. So I believe app.UseWebSockets() can be called multiple times and it will only be added once. So you should be able to add that to your endpoint extension so users don't have to do it themselves.

@joemcbride maybe rename this repo to graphql-dotnet-server as it closer matches the functionality. It already contains a middlware for both normal json queries and subscription transport. I'll separate the middleware for running normal queries to it's own project and nuget package. That should help with some of the requests for "builtin" middlware on main repo.

Use JObject.GetInputs extension method

This is not an issue, just a general question I hope someone can provide some insight for.

We are currently trying to create a Graphql endpoint with an Entity Framework based service layer. Furthermore we try to utilize Dependency Injection in order to inject the dbContext in our Mutation-, Query- and Subscription-implementations. Using Dependency Injection has although proven difficult as the injected dbContext is Scoped by nature. This seems to conflict with how this library require(?) that everything is registered as a Singleton. That said, I believe I've solved it for the HTTP-middleware by creating a custom HTTP-Middleware where the Schema is resolved in the Invoke-method instead of the constructor. The WebSocket-Middleware is although a bit more complicated, and we've not found any elegant solutions to this.

So any advice on using Subscriptions together with a Schema that relies on scoped dependencies will be much appreciated.

We are currently trying to authenticate the clients before allowing them to set up subscriptions. A common way of doing this seems to be to add a token to the payload on the initial connection ( connection_init):

{"type": "connection_init", "payload": {"token": "123456"}}}

This approach is seen here

We have tried to access the payload through OperationMessageContext in the BuildUserContext delegate, but we are not able to get the payload for the initial connection, just the subsequent connections after the ack is received. The intention is to build a usercontext there and do further checks in the validation rules before allowing the subscription.

Is this currently possible in the library or is there another preferred way of doing an initial authentication?

The example Chat.cs uses an ISubject which works fine.

However for me project I get the data from the server using Entity Framework Core.

public class AppSubscription : ObjectGraphType<object>
{
    public AppSubscription(ICommentService commentService)
    {
        AddField(new EventStreamFieldType
        {
            Name = "commentAdded",
            Type = typeof(CommentPayload),
            Resolver = new FuncFieldResolver<Comment.Models.Comment>(c => {
                return (Comment.Models.Comment)c.Source;
            }),
            Subscriber = new EventStreamResolver<Comment.Models.Comment>(c => {
                var comments = repository.GetComments().ToObservable;

                return comments;
            }),
        });
    }
}

public class CommentsRepository {
    public virtual IQueryable<Comment> GetComments()
    {
        return Context.Set<Comment>();
    }
}

The above gives the exception, it seems to call OnCompleted before unSubscribe is assigned which results in Unsubscribe.Dispose() throwing a null reference error:

System.NullReferenceException: Object reference not set to an instance of an object.
at GraphQL.Server.Transports.WebSockets.SubscriptionHandle.OnCompleted()
at System.Reactive.AnonymousSafeObserver1.OnCompleted() at System.Reactive.Linq.ObservableImpl.Merge1.MergeConcurrent.OnCompleted()
at System.Reactive.Linq.ObservableImpl.Select2._.OnCompleted() at System.Reactive.Linq.ObservableImpl.Catch2..OnCompleted()
at System.Reactive.Linq.ObservableImpl.SelectMany2.SelectManyImpl.OnCompleted() at System.Reactive.Linq.ObservableImpl.Select2..OnCompleted()
at System.Reactive.Linq.ObservableImpl.ToObservable1._.LoopRec(State state, Action1 recurse)
at System.Reactive.Concurrency.Scheduler.InvokeRec1[TState](IScheduler scheduler, Pair2 pair) at System.Reactive.Concurrency.ScheduledItem2.InvokeCore()
at System.Reactive.Concurrency.CurrentThreadScheduler.Trampoline.Run(SchedulerQueue1 queue) at System.Reactive.Concurrency.CurrentThreadScheduler.Schedule[TState](TState state, TimeSpan dueTime, Func3 action)
at System.Reactive.Concurrency.LocalScheduler.Schedule[TState](TState state, Func3 action) at System.Reactive.Producer1.SubscribeRaw(IObserver1 observer, Boolean enableSafeguard) at GraphQL.Server.Transports.WebSockets.SubscriptionHandle..ctor(OperationMessage op, IObservable1 stream, IJsonMessageWriter messageWriter, IDocumentWriter documentWriter)
at GraphQL.Server.Transports.WebSockets.SubscriptionProtocolHandler1.<>c__DisplayClass14_0.<AddSubscription>b__0(String connectionId) at System.Collections.Concurrent.ConcurrentDictionary2.AddOrUpdate(TKey key, Func2 addValueFactory, Func3 updateValueFactory)
at GraphQL.Server.Transports.WebSockets.SubscriptionProtocolHandler`1.d__14.MoveNext()

If I replace the above code with the example code it works fine, so it seems to be a problem with how I am using it with EF:

public class AppSubscription : ObjectGraphType<object>
{
    private readonly ISubject<Comment.Models.Comment> _messageStream = new ReplaySubject<Comment.Models.Comment>(1);

    public AppSubscription()
    {
        AddField(new EventStreamFieldType
        {
            Name = "commentAdded",
            Type = typeof(CommentPayload),
            Resolver = new FuncFieldResolver<Comment.Models.Comment>(c => {
                return (Comment.Models.Comment)c.Source;
            }),
            Subscriber = new EventStreamResolver<Comment.Models.Comment>(c => {
                var comments = _messageStream.AsObservable();

                return comments.ToObservable();
            }),
        });
    }
}

In order to simplyficate the process of creating new UI packages.
We should create a lib that uses all this kind of abstractions.
Most of the code is the same except the *.cshtml

First, thanks for this package.

Browser: Latest Chrome

I cloned the examples and ran samples.server through visual studio.

I followed the examples with 2 different windows. The query works fine, the mutation updates the query successful when the page is reloaded as expected but the subscriptions don't work. They just hang on 'listening' with no changes in the response window.

Console error:

client.js:363 WebSocket connection to 'ws://localhost:60340/graphql' failed: Error during WebSocket handshake: Unexpected response code: 500

At the current moment, there is no possibility to use settings in the middleware, like in the example of the GraphQL project.
Currently, I have hacked my way through the project to get this working (I added it to all Contexts etc), but it would be nice to have a clean way to get this implemented.