Code Monkey home page Code Monkey logo

Comments (10)

innermatrix avatar innermatrix commented on July 19, 2024 1

Was there any parts of the V4->V5 migration that could have been made easier somehow (considering how much has changed)? I know there's still a lot of plugins that need porting... 😅

TBD; I am still blocked on that schema generation bug I reported in Discord, and I need to test my lambda adapter; let's talk about that when I get something that at least somewhat works 🙂

from pg-simplify-inflector.

benjie avatar benjie commented on July 19, 2024

Either 1. use PgSimplifyInflectorPlugin.default in appendPlugins or 2. move to V5 where this isn't an issue (I think). Changing the .d.ts file is likely to break many people's applications.

from pg-simplify-inflector.

benjie avatar benjie commented on July 19, 2024

(I made the changes in #42 but have closed it because they were meaningless.)

from pg-simplify-inflector.

innermatrix avatar innermatrix commented on July 19, 2024

@benjie This is definitely a problem in v5 (that is where I first discovered it); see my links in "additional context" in the report above.

from pg-simplify-inflector.

benjie avatar benjie commented on July 19, 2024

It shouldn't be; the V5 plugin (@graphile/simplify-inflection) works great for me and the type checker confirms it's correct:

https://arethetypeswrong.github.io/?p=%40graphile%2Fsimplify-inflection%408.0.0-beta.3

from pg-simplify-inflector.

innermatrix avatar innermatrix commented on July 19, 2024

Oh looks like it got fixed after I reported; you’re right, the latest beta is fine. My bad.

from pg-simplify-inflector.

benjie avatar benjie commented on July 19, 2024

I just checked and 8.0.0-0.2 published 8 months ago does not have this issue; it has never been an issue in V5 as far as I know:

https://arethetypeswrong.github.io/?p=%40graphile%2Fsimplify-inflection%408.0.0-0.2

from pg-simplify-inflector.

innermatrix avatar innermatrix commented on July 19, 2024

Interesting. I have no idea how I ended up with a broken version then; my report was against a 7.x alpha and I have no idea why that landed in my deplist… but I’m sure it was some kind of fever dream trying to get our code ported to v5

from pg-simplify-inflector.

innermatrix avatar innermatrix commented on July 19, 2024

anyhoo sorry for wasting your time!

from pg-simplify-inflector.

benjie avatar benjie commented on July 19, 2024

No problem; I suspect you just tried to use the V4 plugin with V5. I did consider sticking with the V4 plugin name, but it's been annoying me for ages so it seemed a good point to "break" it with a new cleaner name.

Was there any parts of the V4->V5 migration that could have been made easier somehow (considering how much has changed)? I know there's still a lot of plugins that need porting... 😅

from pg-simplify-inflector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.