Comments (3)
boldtrn
commented on August 15, 2024
Sorry I must have missed this issue :). I introduced this resolve in this commit. I might have misinterpreted this case, because for other APIs we do
if (err || !res.ok) {
reject(ghUtil.extractError(res, url));
}
The other cases are assumed to be correct cases. If this case would be indeed an error situation, then we should reject and not resolve. Should I create a PR for this?
from directions-api-js-client.
karussell
commented on August 15, 2024
This is a critical part of the code.
We should poll until either "finished" is set, an http error happend or the JSON is an error message (an http error should be associated as well).
Or maybe it is safer to poll only if status is waiting or processing? WDYT @oblonski ?
from directions-api-js-client.
karussell
commented on August 15, 2024
I think this is fixed.
from directions-api-js-client.
Related Issues (20)
- Update client to use PathDetails
- Host @CDN HOT 2
- How to use Route Optimization API? HOT 1
- Add Coordinate to PathDetails
- Make association of path details to legs easier HOT 3
- Update demo dependencies HOT 1
- Tests Are Failing HOT 4
- Debugging error handling HOT 1
- An error occured: Bad Request HOT 2
- Map matching example -> gray out button if problem was sent
- Make Client more flexible
- make it possible to add multiple block_area HOT 1
- Avoid sending parameters turn_sign_map.-3 etc HOT 8
- Better debugging HOT 6
- Url seems to be build wrong with doRequest HOT 1
- Improve Map Matching usage
- improve memory usage for Routing response HOT 1
- How can I use this library in Angular? HOT 3
- Dead link in ReadMe HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from directions-api-js-client.