grails-plugins / grails-resources Goto Github PK

I'm working on twitter-bootstrap plugin. I notice a problem with some javascript files which has no trailing semicolon at the end. It works fine when browser loads files separately, but when bundled to one file produce not valid javascript code.
It can be handled by adding semicolon (;) at the end of every js file to be included or bundler process can add semicolon. Second solution I think is cleaner, because doesn't require to change js files. What do you think about it?

Thanks,
Karol

Steps to Reproduce

I have installed runtime "org.grails.plugins:resources:1.2.14"
I have created ApplicationResources.groovy inside config directory with a module
I have given <r:require modules="moduleName"/> in a gsp

Expected Behaviour

It should load the static resources

Actual Behaviour

Nothing is happening

Environment Information

Operating System: Mac OS
Grails Version: 3.2.5
JDK Version: 1.7
Container Version (If Applicable): TODO

Some script is accessing /static/css/ on my Grails application. That results in a "String index out of range" exception:

Message: String index out of range: 6
    Line | Method
->> 1963 | substring                in java.lang.String
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
|    570 | makeFileForURI           in org.grails.plugin.resource.ResourceProcessor
|    262 | beginPrepare . . . . . . in org.grails.plugin.resource.ResourceMeta

Version 1.2.14

I have the following code commented out in one of my css files :

and getting the following errors:

is bug? commented out css should be ignored? ..

I was trying to use resources plugin with the latest version of JQuery.

On the plain JQuery plugin I could do that:

jquery {
sources = 'jquery' // Holds the value where to store jQuery-js files /web-app/js/
version = '1.6.4' // The jQuery version in use
}

And the JQuery tag would know how to find that in my own /js/jquery/ directory.
<g:javascript library="jquery" />

I don't want to update the plugin jquery version on the plugin directory, but the resources plugin can't find the .js on my dir. It keeps giving me this exception:

java.lang.IllegalArgumentException: Module [jquery] depends on resource [/plugins/jquery-1.6.1.1/js/jquery/jquery-1.6.4.min.js] but the file cannot be found

I tried to find where to fix that so I could provide a pull request or something like that, but I couldn't. so far. Any help where to find that or maybe you guys could fix that either. :)

Thanks by the way for the great plugin.