The relevant functionality is:
https://statsd.readthedocs.io/en/v3.2.1/types.html#sets

I think we should add the 'set' functionality as described above.

Add middleware for integration with Starlette framework.

Useful links:

• https://www.starlette.io/middleware/

Hi,

Description

We are faced with a strange number of the 500 errors in our metrics (which are collected by aiodogstatsd.contrib.aiohttp middleware) and that number was different from what we at ALB logs. The reason for this - is that when the connection is aborted before we processed it, the CancelledError would be raised -- and it will be counted as a 500 error, but this is not true -- user will not receive any response in that case.

Expected behavior

In the case of CancelledError it would be great to have the option to separate it from other errors and have an option to skip it from the metrics

 try:
     response = await handler(request)
     response_status = response.status
 except web.HTTPException as e:
     response_status = e.status
     raise e
except CancelledError: 
      response_status = ... # some code, that will indicate that is `CancelledError`
 finally:
     if _proceed_collecting(..., collect_canceled=True/False):   # allow to mute CancelledError metric
         ...

It looks like type definitions were moved to separate module in recent aiohttp 3.8.0 and now old imports doesn't work anymore

If app uses variable route, requests with this urls are tagged with full path, which varies between requests.

For example:

...
app.add_route('/some/resource/{some_id}/child', handler)
...

Requests to this route are send to dogstatsd with full path, i.e.:

http_request_duration{method="GET",path="/some/resource/36d12223-1454-461c-9ed5-6d6777d98e80/child" ,",status="200",quantile="0.5"} 0.007255767000060587

It could be more convenient if such requests are reported with path pattern, i.e.:

http_request_duration{method="GET",path="/some/resource/{some_id}/child" ,",status="200",quantile="0.5"} 0.007255767000060587

Quick research shows that this info can be retrieved from request.match_info.route.resource.canonical, but this looks suspiciously long construction to be reliable. ;)

GeneratorExit: null
  File "aiodogstatsd/contrib/aiohttp.py", line 65, in middleware
    response = await handler(request)

UnboundLocalError: local variable 'response_status' referenced before assignment
  File "aiohttp/web_app.py", line 458, in _handle
    resp = await handler(request)
  File "aiohttp/web_middlewares.py", line 119, in impl
    return await handler(request)
  File "aiodogstatsd/contrib/aiohttp.py", line 75, in middleware
    request, response_status, collect_not_allowed, collect_not_found

Need to handle BaseException too.

Hi,
In our use case we've implemented a function for timing asyncio tasks - essentially we have a wrapper function for create_task that adds done callback that sends the metric of duration, if exceeds certain threshold.
I wonder if it's something that would be welcome in this library, if so I'll create a PR!

Need to add useful documentation, but not only about basic library usage. Good to add documentation of how to setup library with AIOHTTP, Sanic and Starlette. Also it’s good to show examples of statsd_exporter and Prometheus integration, maybe even with PromQL queries.

We need to:

• lint code only for the latest supported version of Python
• lint markdown files
• test code (possible we can use matrix strategy)
• build and publish package to PyPI
• (?) think about notifications like package published, pr created, project starred

Useful docs: https://help.github.com/en/actions/automating-your-workflow-with-github-actions

timeit do not report metrics if unhandled exception happens in context block

Thanks for a great library, other than that everything seems to work well.

This caused me a tiny bit of trouble to figure out ... is data dog using 9125 ?

Need to add namespaces support in metric names used in integrations with AIOHTTP, Sanic and Starlette.

Need to limit pending queue size