gpoguy / admxtodsc Goto Github PK

You have scope issues. You define $valueNameHashTable in the main body of your script and expect to reference it inside your nested functions. It most likely works but is not a best practice and could come back later to bite you. If you want to do this you should use a scope identifier like global or script.

Because your internal functions are only called from the main function, there is no need to give them standard names. I often use non-standard names for internal functions to remind me that the user will never see these functions.

What are your long term plans for this? If I have a policy that does things like configure services and event logs, I would want the script to convert those settings to a DSC config because those use out of the box resources like you are using Registry. Eventually, it would be nice to check thinks like a new folder preference and create that configuration using on of the SMBShare resources.

I think the challenge is that the GP cmdlets don't easily expose settings like service configurations. Anyway I'd love to hear more about where you intend to go with this project.

Ran into this one while generating DSCs to test against using DSCEA. With particular policies that have no value listed (see first image below), the Recurse_PolicyKeys function, particularly at line 99's else condition, does not appear to increment past the empty valued key, this getting stuck on it and putting the code into a loop.

For testing, the object it's getting stuck on for me is Computer Configuration > Policies > Software Settings > System > Remote Assistance > Offer Remote Assistance set to Disabled. Script runs without issue when the suspect object is removed from the GPO. Not sure if this condition exists for other objects.

• requires GP cmdlets to function
• extra text at the bottom of the file
• params are not marked mandatory even though they will fail without proper input 😃