Comments (12)
I'm sure! It's unlikely I'll get around to it, but maybe someone who takes the workshop will be inspired :)
from react-redux-realworld-example-app.
Great suggestion! @kentcdodds actually created some for this repo + the node repo over at https://github.com/kentcdodds/testing-workshop.
Maybe we could convince him to make a PR back here at some point :) 🙏
from react-redux-realworld-example-app.
Perhaps! Though I did make a number of changes to make the code more testable. 🙃
from react-redux-realworld-example-app.
@EricSimons I wrote some unit tests and changed a little bit of code to be more clean, i would love to write a full test suite for this, should i pr the initial tests so you see if they are okay before moving on?
from react-redux-realworld-example-app.
That would be great :)
from react-redux-realworld-example-app.
In that case, we'd love to have those changes PR'd 🙌😄
from react-redux-realworld-example-app.
@justDanielMata yes absolutely!! 🙌
from react-redux-realworld-example-app.
@EricSimons i'm probably dumb, but it is the first time i create a pull request for an oss project, how do i create the pr? it says i'm inauthorized on my terminal.
from react-redux-realworld-example-app.
@justDanielMata github actually has a button in the UI that will automatically do that PR for you — where is your current forked repo located?
from react-redux-realworld-example-app.
from react-redux-realworld-example-app.
Yup! Heres some more info on how to do it: https://stackoverflow.com/questions/14680711/how-to-do-a-github-pull-request
from react-redux-realworld-example-app.
Is the effort on adding tests still going on?
from react-redux-realworld-example-app.
Related Issues (20)
- Application is not working with standalone backend HOT 1
- Can you please update this project HOT 5
- Minor changes need to take care HOT 2
- Use the Redux Toolkit library throughout the app
- how to add tags for articles? HOT 3
- Email / Password Always Invalid On Login Attempt HOT 1
- middlewares are not applied on react native HOT 1
- Whenever I come back to the home page from any other page It still shows the previously selected popular tag active and the articles under it are not filtered accordingly. Its showing global feed's articles.
- Real world
- There is no separate file for Action,reducer
- Is it justified to use redux for an application of this scale?
- Error use Laravel with React Js
- Updating to latest react, using react hooks, converting to functional components from class components HOT 1
- Unhandled Rejection (TypeError): Cannot read property 'tags' of undefined when trying to run with local Node Express backend HOT 1
- react-router-redux is deprecated
- Follow and favorite buttons not showing up on article page
- Unhandled Rejection (TypeError): Cannot read property '0' of null
- Your Feed pagination broken, not adding offset
- No pagination for My Articles and Favorited Articles of a user
- Unmaintained repository
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-redux-realworld-example-app.