Testing support? about react-redux-realworld-example-app HOT 12 OPEN

I'm sure! It's unlikely I'll get around to it, but maybe someone who takes the workshop will be inspired :)

from react-redux-realworld-example-app.

Great suggestion! @kentcdodds actually created some for this repo + the node repo over at https://github.com/kentcdodds/testing-workshop.

Maybe we could convince him to make a PR back here at some point :) 🙏

from react-redux-realworld-example-app.

Perhaps! Though I did make a number of changes to make the code more testable. 🙃

from react-redux-realworld-example-app.

@EricSimons I wrote some unit tests and changed a little bit of code to be more clean, i would love to write a full test suite for this, should i pr the initial tests so you see if they are okay before moving on?

from react-redux-realworld-example-app.

That would be great :)

from react-redux-realworld-example-app.

In that case, we'd love to have those changes PR'd 🙌😄

from react-redux-realworld-example-app.

@justDanielMata yes absolutely!! 🙌

from react-redux-realworld-example-app.

@EricSimons i'm probably dumb, but it is the first time i create a pull request for an oss project, how do i create the pr? it says i'm inauthorized on my terminal.

from react-redux-realworld-example-app.

@justDanielMata github actually has a button in the UI that will automatically do that PR for you — where is your current forked repo located?

from react-redux-realworld-example-app.

from react-redux-realworld-example-app.

Yup! Heres some more info on how to do it: https://stackoverflow.com/questions/14680711/how-to-do-a-github-pull-request

from react-redux-realworld-example-app.

Is the effort on adding tests still going on?

from react-redux-realworld-example-app.