gostevehoward / confseq Goto Github PK

View Code? Open in Web Editor NEW

51.0 51.0 3.0 907 KB

Confidence sequences and uniform boundaries

License: MIT License

Python 13.52% C++ 82.29% Makefile 0.68% CMake 0.99% M4 0.68% C 0.50% Shell 0.54% R 0.32% Starlark 0.48%

confseq's People

Contributors

Stargazers

Watchers

Forkers

mysticaltech wannabesmith ggavrilos

confseq's Issues

gcc cannot find "uniform_boundaries.h" when installing through pip

When I run pip3 install confseq, gcc complains it cannot find "uniform_boundaries.h" when building confseq.boundaries extension.

    building 'confseq.boundaries' extension
    creating build/temp.linux-x86_64-3.9
    creating build/temp.linux-x86_64-3.9/src
    creating build/temp.linux-x86_64-3.9/src/confseq
    gcc -pthread -B /private/home/xxx/.conda/envs/my_env/compiler_compat -Wl,--sysroot=/ -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /private/home/xxx/.conda/envs/my_env/include -fno-semantic-interposition -fPIC -O2 -isystem /private/home/xxx/.conda/envs/my_env/include -fno-semantic-interposition -fPIC -I/private/home/xxx/.conda/envs/my_env/lib/python3.9/site-packages/pybind11/include -I/private/home/xxx/.conda/envs/my_env/lib/python3.9/site-packages/pybind11/include -I/private/home/xxx/.conda/envs/my_env/include/python3.9 -c src/confseq/boundaries.cpp -o build/temp.linux-x86_64-3.9/src/confseq/boundaries.o -DVERSION_INFO="0.0.5" -std=c++14 -fvisibility=hidden
    src/confseq/boundaries.cpp:4:10: fatal error: uniform_boundaries.h: No such file or directory
        4 | #include "uniform_boundaries.h"
          |          ^~~~~~~~~~~~~~~~~~~~~~
    compilation terminated.
    error: command '/usr/bin/gcc' failed with exit code 1

I installed your package successfully last year; the failure appears when installing it on my server and new laptop. I wonder if the recent change you made broke the installation.

Add running_intersection function rather than performing this step in each CS implementation

Referenced in #6.

Argument num_successes in bernoulli_confidence_interval only accepts ints

The documentation of function bernoulli_confidence_interval implies that argument num_successes could take real values:

* `num_successes`: number of "successful" Bernoulli trials seen so far,
      or more generally, sum of observed outcomes.

However, the code seems to allow only integer-valued arguments. In python

y = np.random.uniform(size=100)
boundaries.bernoulli_confidence_interval(  
    num_successes=np.sum(y),  # Argument is float
    num_trials=100, 
    alpha=0.1, 
    t_opt=100, 
    alpha_opt=0.1)

leads to this error:

TypeError: bernoulli_confidence_interval(): incompatible function arguments. The following argument types are supported:
    1. (num_successes: int, num_trials: int, alpha: float, t_opt: float, alpha_opt: float = 0.05) -> Tuple[float, float]
Invoked with: kwargs: num_successes=51.445863688932626, num_trials=100, alpha=0.1, t_opt=100, alpha_opt=0.1

The message disappears if we replace e.g., np.sum(y) by int(np.sum(y)).

gostevehoward / confseq Goto Github PK

confseq's People

Contributors

Stargazers

Watchers

Forkers

confseq's Issues

gcc cannot find "uniform_boundaries.h" when installing through pip

Add running_intersection function rather than performing this step in each CS implementation

Argument num_successes in bernoulli_confidence_interval only accepts ints

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent