allow this:

class Component {
  @command
  get myCommand() {
    if (someCond) {
      return [commandA, commandB];
    }
  }
}

at the moment, the @command decorator doesn't understand getters.

The type="button" attribute is placed when it is not a link, that also means it is placed when it is neither a link nor an action, which is wrong.

Only have the attribute when this is an action.

As part of #31 it was tried to add API docs (similar to ember-link) but typedoc cannot understand gts files and pointing it at dts files output of glint didn't create the expected output.

This needs some revisiting. Probably could be a package in ember that extracts APIs into a common format, that can be rendered by various tools. Ideally a format already in use.

As for migrating into a v2 addon, the instanceof checks have been replaced with duck-type testing, due to embroider-build/ember-auto-import#503

Once the mentioned issue is solved, this can be reworked, by searching the code for links to this issue

Allow this to work:

class MyComponent extends Component {
  link = this.linkMananger.createLink({...});

  @command = commandFor([new LinkCommand(this.link)]);
}

which would enable this:

{{! invocation }}
<MyComponent @link={{link "..."}}/>

{{! template.hbs

<Button @push={{this.go}}>let's go</Button>

and

interface Args {
  link: Link;
}

class MyComponent extends Component<Args> {
  @command
  go = commandFor([
    new LinkCommand(this.args.link),
    new OtherCommand()
  ]);
}

Adding a "command" in template-only form with just (set) will break further execution. So let's accept it.

Simply:

<MyComponent @link={{link ...}}/>

inside the component:

export default class MyComponent extends Component {
  @command
  go = commandFor([
    this.args.link,
    this.somethingElse
  ]);
}

and then writing tests for this:

test('it can follow the link', function () {
  this.link = linkFor('somewhere');
  this.link.onTransitionTo = () => assert.step('link clicked');

  await render(hbs`<MyComponent @link={{this.link}}/>`);

  await click(...);

  assert.verifySteps(['link clicked']);
});

the click() will actually make the link to be transitioned and not prevented.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Pin dependencies (@gossi/config-eslint, @gossi/config-prettier, @gossi/config-template-lint, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, ember-template-lint, eslint, eslint-plugin-ember, prettier)
• Pin dependencies (@types/qunit, @types/rsvp, @types/sinon)
• Pin dependencies (concurrently, ember-qunit, ember-source-channel-url, ember-try, qunit, qunit-dom)
• Update dependency @glint/core to ^1.4.0
• Update dependency @glint/environment-ember-loose to ^1.4.0
• Update dependency @glint/environment-ember-template-imports to v1.4.0
• Update dependency @glint/template to ^1.4.0
• Update dependency ember-cli-typescript to ^5.3.0
• Update dependency ember-sinon-qunit to ^7.4.0
• Update dependency release-it to ^16.3.0
• Update dependency typescript to ^5.4.3
• Update dependency webpack to ^5.91.0
• Update pnpm to v8.15.6
• Update Framework Dependencies (major) (@embroider/addon-dev, ember-resolver, ember-source)
• Update Lint Dependencies (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser, ember-template-lint, eslint-plugin-ember)
• Update Node.js to v20
• Update Testing Dependencies (major) (concurrently, ember-qunit, ember-try, qunit-dom)
• Update actions/configure-pages action to v5
• Update actions/deploy-pages action to v4
• Update actions/upload-pages-artifact action to v3
• Update dependency @types/sinon to v17
• Update dependency ember-cli to v5
• Update dependency ember-cli-babel to v8
• Update dependency ember-concurrency to v4
• Update dependency ember-template-imports to v4
• Update dependency release-it to v17
• Update dependency rollup to v4
• Update dependency sinon to v17
• Lock file maintenance
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Pin dependencies (@babel/core, @babel/eslint-parser, @babel/plugin-proposal-class-properties, @babel/plugin-proposal-decorators, @babel/preset-typescript, @babel/runtime, @ember/string, @ember/test-helpers, @glimmer/interfaces, @glimmer/manager, @glint/core, @glint/environment-ember-loose, @glint/environment-ember-template-imports, @glint/template, @release-it-plugins/lerna-changelog, @rollup/plugin-babel, @rollup/plugin-node-resolve, @rollup/plugin-typescript, @tsconfig/ember, ember-cli-babel, ember-cli-htmlbars, ember-cli-typescript, ember-concurrency, ember-element-helper, ember-link, ember-sinon-qunit, ember-template-imports, loader.js, pnpm-sync-dependencies-meta-injected, release-it, rollup, rollup-plugin-glimmer-template-tag, sinon, typedoc, typedoc-plugin-markdown, typedoc-vitepress-theme, typescript, vitepress, webpack)
• Pin dependencies (@ember/optional-features, @embroider/addon-dev, @embroider/compat, @embroider/macros, @embroider/test-setup, @embroider/webpack, @glimmer/component, @glimmer/tracking, ember-disable-prototype-extensions, ember-load-initializers, ember-resolver, ember-source)
• Pin dependencies (broccoli-asset-rev, ember-auto-import, ember-cli, ember-cli-dependency-checker, ember-cli-inject-live-reload, ember-cli-sri)
• Update dependency pnpm-sync-dependencies-meta-injected to ^0.0.10
• Update dependency typedoc-plugin-markdown to ^4.0.0-next
• Update dependency typedoc-vitepress-theme to ^1.0.0-next
• Update Node.js to v18.20.0
• Update babel monorepo (@babel/core, @babel/eslint-parser, @babel/plugin-proposal-decorators, @babel/preset-typescript, @babel/runtime)
• Update dependency @glimmer/interfaces to ^0.91.0
• Update dependency @glimmer/manager to ^0.91.0
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository