Code Monkey home page Code Monkey logo

openasar's Introduction

openasar's People

Contributors

alsogamer avatar assassinduck avatar canadahonk avatar dreaming-codes avatar ianmanske avatar kyiro avatar transkat avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

openasar's Issues

Mistake in Wiki

Screenshot_2022-01-12-01-17-47_2560x1440

After some debate in the Discord, it seems changing the line

Linux: depends on how you installed, find your exe I guess

to

Linux: most likely /opt/discord/resources/app.asar, however, this may vary based on your installation method

would be a good idea.

[ThemeSync] Some themes don't sync properly (?)

I use a theme that lives in my quickcss (in goosecord) since the version of the dracula theme i use isn't in the goosemod repos port request, anyways it would be nice if the themeSync option supported quickcss options in client mods or maybe a quickcss option was added! This is probably useless to all normal users.

[General] Plugins system?

Develop plugins system to have parts of OA separated out (and allow external dev in future?)? Unsure on

[Feature] Make full libre / "free" version?

Make a version (/ setting?) of OA which is completely libre / "free". Possible by using GU as update host instead of official API and not using Discord's assets in splash.

[Recovery] Try and add crash recovery?

Try and add crash recovery (hard client crash on startup)

Could:

  • Force update OpenAsar
  • Force update Discord?
  • Try and recommend (not do) temporary solutions (disabling mods, etc)

Audio glitches on Ubuntu (only some users?)

When I use the application with the normal asar it works fine, but when I use the open one strange things happen. Sound in the program works as expected but when joining a call, the audio gets crusty. Not like quality crusty, but unlistenably crusty. I really like this as a solution, but I hope this can be resolved

Disconnected internet causes splash to hang

If my internet is disconnected, as generally happens for me when my OS starts discord before my wifi connects, the splash will sit on checking for updates phase repeatedly, instead of just trying again after the internet re-connects, as stock app.asar does.

Screenshot of DevTools in splash:
image

Is it safe

I am asking this question to confirm that it's safe and free from any vulnerabilities so I could share with others and on my youtube channel and even use it thanks. Meaning I want to confirm that you are agree it does not have any type of vulnerability and you are liable for any loss of data or password etc

emoji in readme doesen't load

emoji in the readme.md doesen't load in windows 10, latest vivaldi version. not a big deal, but could be replaced for a different one
image

[Splash] Fully custom themes

Todo:

  • Find example of a good splash idea to create as demo
  • Integrate theme as option in settings.json via theme CSS url (?)

[General] Deep Integration

We have been doing more and more "deep integration" (util file -> within 1 file which uses it) lately, seems to have seemingly large savings in terms of size, also somewhat nicer code as less small files to manage which were only used by one other file anyway.

  • Backoff
  • Settings
  • RetainAsar
  • App Updater
  • u2QuickLoad

[Request] scroll speed modifier

Is it possible to include a scroll speed modifier? The scrolling speed of electron applications on Linux is excruciatingly slow. There are some solutions, such as imwheel, but they are too hacky (just sends multiple scroll events to increase speed). So, if it is possible to do so through the asar file, please let me know.

[Polish] Polish pass

Polish pass is needed before 1.0 is officially done. Polish up UI and gracefully handling common / normal failures / errors.

UI

Graceful Failing

Freezing when clicking links

This is a minor issue, but sometimes when I click a link discord either freezes or crashes

OS: Ubuntu
Browser: Firefox
Client: BetterDiscord

[Config] Explain focus better?

  • Explain focus better, possibly descriptions for each item?
  • Rename "battery saver" / etc to something more about resource saving? (as force uses low power GPU / etc)

Asks to login everytime on startup

Discord Build: Stable 108924 (eb8c571)
OpenAsar Build: Nightly - OpenAsar 1a7d927
OpenAsar Settings: Default (Out of the box)
Operating System: Windows 10 64-bit
Modifications: None

Description: Discords tries to use browser hand-off key auth whenever I start discord, when that doesn't work it asks me to login manually. This happens every time I open discord but reloads work just fine. I suspect its something to do with not being able to store the credentials to disk. It's just a hunch and I don't have any evidence of it.

Steps to Reproduce:

  1. Log out to Discord
  2. Install OpenAsar
  3. Open Discord
  4. And there you go, you're at the login page. (or it uses a browser hand off key)

[Mac] Yauzl frozen open

When using OpenAsar on Discord Canary on macOS, the installation on startup for modules updates invariably stops on "Installing update 3 of 10." The update installation doesn't proceed past that point no matter how long I wait. If I quit and restart Canary, the updater still fails, stalling on "Installing update 1 of 8" as it tries to continue where it left off. The logo keeps spinning, but no more modules are installed.

Canary stays on this screen indefinitely until I quit the app:

discord-updates-stuck-openasar

When I start Discord from Terminal for a modules update, this is what the console shows (with my name redacted):

<username>@<name>'s-MacBook-Pro MacOS % ./Discord\ Canary
Hello from Powercord!
Loading Discord
[OpenAsar > Init] OpenAsar vnightly-c51e4c1
[OpenAsar > Init] Resources Path: /Applications/Discord Canary.app/Contents/Resources
[OpenAsar > AppSettings] Loaded settings.json with path /Users/<username>/Library/Application Support/discordcanary/settings.json with settings {
  BACKGROUND_COLOR: '#202225',
  IS_MAXIMIZED: true,
  IS_MINIMIZED: false,
  WINDOW_BOUNDS: { x: 0, y: 25, width: 1440, height: 815 }
} and last modified 1633584725838
[OpenAsar > Init] Loaded config {}
[OpenAsar > CmdSwitches] Preset: perf
[OpenAsar > CmdSwitches] Switches: --flag-switches-begin --enable-gpu-rasterization --enable-zero-copy --ignore-gpu-blocklist --enable-hardware-overlays=single-fullscreen,single-on-top,underlay --enable-features=EnableDrDc,CanvasOopRasterization,BackForwardCache:TimeToLiveInBackForwardCacheInSeconds/300/should_ignore_blocklists/true/enable_same_site/true,ThrottleDisplayNoneAndVisibilityHiddenCrossOriginIframes,UseSkiaRenderer,WebAssemblyLazyCompilation --disable-features=Vulkan --force_high_performance_gpu --enable-quic --flag-switches-end
[OpenAsar > CmdSwitches] Appended switch flag-switches-begin undefined
[OpenAsar > CmdSwitches] Appended switch enable-gpu-rasterization undefined
[OpenAsar > CmdSwitches] Appended switch enable-zero-copy undefined
[OpenAsar > CmdSwitches] Appended switch ignore-gpu-blocklist undefined
[OpenAsar > CmdSwitches] Appended switch enable-hardware-overlays single-fullscreen,single-on-top,underlay
[OpenAsar > CmdSwitches] Appended switch enable-features EnableDrDc,CanvasOopRasterization,BackForwardCache:TimeToLiveInBackForwardCacheInSeconds/300/should_ignore_blocklists/true/enable_same_site/true,ThrottleDisplayNoneAndVisibilityHiddenCrossOriginIframes,UseSkiaRenderer,WebAssemblyLazyCompilation
[OpenAsar > CmdSwitches] Appended switch disable-features Vulkan
[OpenAsar > CmdSwitches] Appended switch force_high_performance_gpu undefined
[OpenAsar > CmdSwitches] Appended switch enable-quic undefined
[OpenAsar > CmdSwitches] Appended switch flag-switches-end undefined
[OpenAsar > Bootstrap] Forcing Electron props
[OpenAsar > BuildInfo] Loaded build info { releaseChannel: 'canary', version: '0.0.281' }
[OpenAsar > ErrorHandler] Inited
[OpenAsar > Paths] Init! Returns:
getUserData: /Users/<username>/Library/Application Support/discordcanary
getUserDataVersioned: /Users/<username>/Library/Application Support/discordcanary/0.0.281
getResources: /Applications/Discord Canary.app/Contents/Resources
getModuleDataPath: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules
getInstallPath: null
true false
[OpenAsar > Bootstrap] Start minimized: false
[Modules] Modules initializing
[Modules] Distribution: remote
[Modules] Host updates: enabled
[Modules] Module updates: enabled
[OpenAsar > Mkdirp] Sync: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending
[Modules] Module install path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules
[Modules] Module installed file path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/installed.json
[Modules] Module download path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending
[OpenAsar > Splash] Initing splash
[OpenAsar > Splash] Created BrowserWindow
[OpenAsar > Splash] Failed to inject splash CSS
file:///Applications/Discord Canary.app/Contents/Resources/app.asar/splash/index.html?oaVersion=nightly-c51e4c1&oaConfig={}
[OpenAsar > Splash] Loading window (with url file:///Applications/Discord Canary.app/Contents/Resources/app.asar/splash/index.html)
[OpenAsar > Splash] Quickstart config: undefined - undefined undefined
[Modules] Installing updates...
[Modules] Installing discord_desktop_core@9 from /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending/discord_desktop_core-9.zip
[OpenAsar > Yauzl] Zip path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending/discord_desktop_core-9.zip Extract path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/discord_desktop_core
[OpenAsar > Yauzl] Spawned
[OpenAsar > Yauzl] Closed
[Modules] Installing discord_erlpack@9 from /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending/discord_erlpack-9.zip
[OpenAsar > Yauzl] Zip path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending/discord_erlpack-9.zip Extract path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/discord_erlpack
[OpenAsar > Yauzl] Spawned
[OpenAsar > Yauzl] Closed
[Modules] Installing discord_spellcheck@9 from /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending/discord_spellcheck-9.zip
[OpenAsar > Yauzl] Zip path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/pending/discord_spellcheck-9.zip Extract path: /Users/<username>/Library/Application Support/discordcanary/0.0.281/modules/discord_spellcheck
[OpenAsar > Yauzl] Spawned
[OpenAsar > Splash] Window declared ready, showing and starting update process

The updater stalls after the last line, and the app looks like the screenshot above.

I am using:

  • macOS 12.1
  • Discord Canary v0.0.281, latest build (build ID 9bad1ef, build number 111330)
  • OpenAsar Nightly, latest release (c51e4c1)
  • Powercord v2, latest version (12de9dc)

Uninjecting Powercord does not do anything to help this issue; only replacing app.asar with Discord's version makes the module updater work as intended. The first two lines of the console output above ("Hello from Powercord!" and "Loading Discord") go away without Powercord, but that's the only difference.

I noticed this bug when I installed OpenAsar on Canary a couple of days ago and subsequently tried to install a modules update, and it's been an issue for every OpenAsar build and Canary modules update that I've installed so far. I haven't been able to test whether this issue also affects stable Discord, given the lower frequency of updates. For now, I've been switching back and forth between OpenAsar for normal use and Discord's app.asar, which does not have this problem, for installing modules updates.

The module where the updater gets stuck appears to be discord_spellcheck, based on the console and the contents of the modules folder. discord_desktop_core and discord_erlpack, which update first without any problems, appear to only consist of individual files (including .asar and .node files), while discord_spellcheck has a particularly large (16.7 MB) node_modules directory. Perhaps that has something to do with it?

Edit: but the unzip command works fine from Terminal...so that can't be why it's not working, can it?

[PR] 1.0 Release Schedule

Dev

Marketing (Prep)

  • Analyse website is understandable / etc
  • Ensure stats are up to date
  • Vague video showcasing more obvious demo?

Release

  • Release RC as normal nightly
  • Gather feedback and testing
  • RC -> "1.0"

PR - Internal / Self

  • GN Discord announcement
  • Advertise with GM notice?

PR - External

  • Accidental video

TBD

[CI] Add Windows testing

Currently only Linux, adding Windows testing would allow testing to cover more code which otherwise is untested (during dev and CI). Requires build flow / suite rewrite due to using bash scripts / etc

Launcher will hang if started without internet

The launcher will hang on checking for updates when started without internet. When internet is restored, it will still be stuck in this state unless restarted.
This is a problem because since I am on wifi, discord will automatically start before the network has finished making a connection.

This may be related to #4.

[General] Complete rewrite

Rewrite 100% of source, currently estimated at around 90% done. Mostly unneeded rewrites which will be a hassle to do cleanly like splash backend and some leftover updater parts.

Files left todo:

  • Splash backend
  • Module updater
  • Updater v2 (win32 only)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.