Code Monkey home page Code Monkey logo

Comments (7)

samthor avatar samthor commented on August 23, 2024

I could do this but I'm not sure of the added value. I suspect most sites that are reading this kind of meta from the HTML itself aren't running the page's JS—think e.g., sharing a link on Twitter.

Is there another reason why this might be useful?

from pwacompat.

hnordt avatar hnordt commented on August 23, 2024

The main reason is to avoid this Lighthouse's warning:

Img

https://developers.google.com/web/tools/lighthouse/audits/description

from pwacompat.

samthor avatar samthor commented on August 23, 2024

I really believe that most crawlers/etc are not going to run page JavaScript just to read your site's meta tags.

So while it might make Lighthouse happy, I suspect this change won't actually improve your SEO.

from pwacompat.

hnordt avatar hnordt commented on August 23, 2024

I understand your point, but I'm not sure it would be a bad thing. You could just check if there is a meta description already and add one based on manifest if not.

Just as theme_color, I don't like to have to duplicate it on my HTML head.

from pwacompat.

Malvoz avatar Malvoz commented on August 23, 2024

Unlike <title> (under some circumstances) a <meta> description isn't required in HTML. If you don't need it, should you add it just to appease the Lighthouse tool?

I really believe that most crawlers/etc are not going to run page JavaScript just to read your site's meta tags.

So while it might make Lighthouse happy, I suspect this change won't actually improve your SEO.

I haven't googled it but I'm quite sure Google can index script-generated content, however if Google saw the same <meta> description across several pages then the site-owner may start worrying about "SEO penalties" due to duplicate content.

Personally I don't think this is a good default for PWACompat.

from pwacompat.

samthor avatar samthor commented on August 23, 2024

Sorry @hnordt but I also don't think this is worth including.

PWACompat is not intended to help with search indexability. I've had #22 filed and I'll mention this as part of resolving that issue.

from pwacompat.

hnordt avatar hnordt commented on August 23, 2024

Thank you for having a look at it @samthor. I agree with you.

from pwacompat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.