Code Monkey home page Code Monkey logo

Comments (10)

samthor avatar samthor commented on August 23, 2024 6

In exciting news, looks like new Safari betas might resolve this issue.

from pwacompat.

samthor avatar samthor commented on August 23, 2024 1

So this seems to me to be a fundamental problem with the way iOS uses PWAs; it's not really anything to do with PWACompat except for the fact that PWACompat configures iOS on your behalf.

I'm not against having a "no-on-ios" modifier, but to me, the primary use-case of this library is to support iOS. So if PWAs aren't working on iOS because you have these kinds of auth flows, I'd probably suggest not using PWACompat for the time being.

from pwacompat.

maku-zuhlke avatar maku-zuhlke commented on August 23, 2024 1

Thanks @samthor. I can confirm that iOS 12.2.0 fixes the issue for us. πŸŽ‰πŸŽ‰πŸŽ‰

from pwacompat.

jvitor83 avatar jvitor83 commented on August 23, 2024

Some considerations about iOS: https://medium.com/@firt/you-shouldnt-use-chrome-s-pwacompat-library-in-your-progressive-web-apps-6b3496faab62

from pwacompat.

jvitor83 avatar jvitor83 commented on August 23, 2024

For what i could see, the issue is with the manifest (iOS implementation) and not with the apple-mobile-web-app-capable . This is why the workaround works!

from pwacompat.

paul-sachs avatar paul-sachs commented on August 23, 2024

Unfortunately, I think this hack doesn't seem to work anymore. I was just testing it out with my own app on iOS simulator (12.1) and all external links still open safari instead, even without the manifest available. Not sure if something has changed. Tried this without the added complexity of pwacompat, still no dice. Was really hoping to get SSO working but without the redirect, I'm going to have to find another route.

from pwacompat.

digitaltickle avatar digitaltickle commented on August 23, 2024

I just hit this same issue - Auth with redirect is fine for Google and FB within Safari, but as soon as you add the PWA to the homescreen, the Auth process opens in Safari then tries to redirect to Safari too - leaving the PWA un-auth'd. Bugger.

from pwacompat.

Chris-KCIT avatar Chris-KCIT commented on August 23, 2024

I'm not against having a "no-on-ios" modifier, but to me, the primary use-case of this library is to support iOS. So if PWAs aren't working on iOS because you have these kinds of auth flows, I'd probably suggest not using PWACompat for the time being.

For me, I wish to have the manifest in place for non-iOS users and have my site open in browser for iOS users until apple get their act together.

from pwacompat.

samthor avatar samthor commented on August 23, 2024

If that's the case, the JavaScript suggested above could be included in your own bundle or inline in the HTML. This just really isn't a PWACompat issue Β―\_(ツ)_/Β―

from pwacompat.

Chris-KCIT avatar Chris-KCIT commented on August 23, 2024

Indeed I have included the above code, it is working very well. As soon as these Safari issues are resolved by Apple I can go back to using PWACompat for my poor iOS users :o for now they will be using our system in a Safari window.

from pwacompat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.