googlechromelabs / chrome-devrel-review-bot Goto Github PK

This could be a clue that the author hasn't thought about linking out.

Hello, Issues!

Instead of always returning an HTTP 200 in /approvals handler, we should propagate some errors that come from handling the webhook and use those to trigger an error response whose body contains details about the failure.

https://docs.github.com/en/github-ae@latest/rest/guides/best-practices-for-integrators#use-appropriate-http-status-codes-when-responding-to-github makes it sound like including errors about the failure in the response body could be helpful in debugging.

context: #12

• Draft

I think we could save ourselves some sanity by migrating this to GitHub actions. The main motivation is getting rid of using Glitch as a sort of production backend but also:

• being able to trace runs via the GitHub actions UI (why did a run fail, when did it run, ...)
• making use of action annotations to visually connect Markdown lint errors to the PR code. This will make reviews easier
• being able to use existing actions like Sticky Pull Request comment to reduce noise

In GoogleChrome/web.dev#8373 (comment) the bot flagged "OCD" in the source text. However, the offending line is this:

thumbnail: image/jL3OLOhcWUQDnR4XjewLBx4e3PC3/dUBhcdiLqE1OCDUV7ZYm.jpg

https://github.com/GoogleChrome/web.dev/blob/e3b960500b31b8b0f0d143e41ff133a022361e28/src/site/content/en/blog/godaddy/index.md?plain=1#L12

Consider checking for boundaries on either side of the bad words to avoid false positives, ie /\bOCD\b/.

• Draft