Comments (5)
The project already has a firebase.json
, so I would assume it reads the features from that file. If that is not the case then we could just change it to firebase init hosting
, as Hosting is the only feature we need for this project.
from kino.
Is this intended that firebase.json
file is updated after running firebase init hosting
command?
$ firebase init hosting
######## #### ######## ######## ######## ### ###### ########
## ## ## ## ## ## ## ## ## ## ##
###### ## ######## ###### ######## ######### ###### ######
## ## ## ## ## ## ## ## ## ## ##
## #### ## ## ######## ######## ## ## ###### ########
You're about to initialize a Firebase project in this directory:
/XXXXXXXXX/GitHub/kino
Before we get started, keep in mind:
* You are initializing within an existing Firebase project directory
=== Project Setup
First, let's associate this project directory with a Firebase project.
You can create multiple project aliases by running firebase use --add,
but for now we'll just set up a default project.
i .firebaserc already has a default project, using XXXXXX.
=== Hosting Setup
Your public directory is the folder (relative to your project directory) that
will contain Hosting assets to be uploaded with firebase deploy. If you
have a build process for your assets, use your build's output directory.
? What do you want to use as your public directory? public
? Configure as a single-page app (rewrite all urls to /index.html)? No
? Set up automatic builds and deploys with GitHub? No
✔ Wrote public/404.html
? File public/index.html already exists. Overwrite? No
i Skipping write of public/index.html
i Writing configuration info to firebase.json...
i Writing project information to .firebaserc...
✔ Firebase initialization complete!
$ git diff
diff --git a/firebase.json b/firebase.json
index a570099..e782939 100644
--- a/firebase.json
+++ b/firebase.json
@@ -1,10 +1,6 @@
{
"hosting": {
"public": "public",
- "rewrites": [{
- "source": "**",
- "destination": "/index.html"
- }],
"ignore": [
"firebase.json",
"**/.*",
from kino.
No, it is not intended that it would update the config file. What we want would be to initialize Firebase so it creates the .firebaserc
but does not change the config file. The docs on that CLI command are very sparse.
from kino.
I think the option Configure as a single-page app (rewrite all urls to /index.html)? should be set to Yes and then it would leave the config file as-is.
from kino.
Thank you @derekherman! You're right.
Here's the PR: #159
from kino.
Related Issues (20)
- Offline to Online: Partially downloaded file is paused when SW goes offline, but UI indicates download is continuing
- Video greyed out and cannot click "remove offline version" after hard reload (Ctrl-Shift-R) in offline mode HOT 2
- IndexDB not being freed up when removing offline video from within webapp HOT 3
- The app needs to handle 404s correctly
- Improve Lighthouse scores HOT 10
- Add code highlighting
- Create a guide for contributors
- Fix CORS issues HOT 5
- Display video artwork in the Media Session API
- Add linter for the Markdown with frontmatter support
- Autoplay research and implementation
- Could not append initialization segment to source buffer HOT 7
- Button "Resume download" is not displayed when internet connection is cut while downloading a video HOT 1
- Multiple videos can be played at the same time when they're being played in PiP mode HOT 1
- Hide "Cast" button when there are no devices to cast HOT 1
- Continue download and cancel download buttons become irresponsive
- Stop first video when second video starts playing HOT 2
- Hard refresh required to get new content.
- HTML Samples are encoded when they shouldn't be
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kino.