Code Monkey home page Code Monkey logo

Comments (5)

derekherman avatar derekherman commented on May 24, 2024

The project already has a firebase.json, so I would assume it reads the features from that file. If that is not the case then we could just change it to firebase init hosting, as Hosting is the only feature we need for this project.

from kino.

beaufortfrancois avatar beaufortfrancois commented on May 24, 2024

Is this intended that firebase.json file is updated after running firebase init hosting command?

$ firebase init hosting

     ######## #### ########  ######## ########     ###     ######  ########
     ##        ##  ##     ## ##       ##     ##  ##   ##  ##       ##
     ######    ##  ########  ######   ########  #########  ######  ######
     ##        ##  ##    ##  ##       ##     ## ##     ##       ## ##
     ##       #### ##     ## ######## ########  ##     ##  ######  ########

You're about to initialize a Firebase project in this directory:

  /XXXXXXXXX/GitHub/kino

Before we get started, keep in mind:

  * You are initializing within an existing Firebase project directory


=== Project Setup

First, let's associate this project directory with a Firebase project.
You can create multiple project aliases by running firebase use --add, 
but for now we'll just set up a default project.

i  .firebaserc already has a default project, using XXXXXX.

=== Hosting Setup

Your public directory is the folder (relative to your project directory) that
will contain Hosting assets to be uploaded with firebase deploy. If you
have a build process for your assets, use your build's output directory.

? What do you want to use as your public directory? public
? Configure as a single-page app (rewrite all urls to /index.html)? No
? Set up automatic builds and deploys with GitHub? No
✔  Wrote public/404.html
? File public/index.html already exists. Overwrite? No
i  Skipping write of public/index.html

i  Writing configuration info to firebase.json...
i  Writing project information to .firebaserc...

✔  Firebase initialization complete!
$ git diff
diff --git a/firebase.json b/firebase.json
index a570099..e782939 100644
--- a/firebase.json
+++ b/firebase.json
@@ -1,10 +1,6 @@
 {
   "hosting": {
     "public": "public",
-    "rewrites": [{
-      "source": "**",
-      "destination": "/index.html"
-    }],
     "ignore": [
       "firebase.json",
       "**/.*",

from kino.

derekherman avatar derekherman commented on May 24, 2024

No, it is not intended that it would update the config file. What we want would be to initialize Firebase so it creates the .firebaserc but does not change the config file. The docs on that CLI command are very sparse.

from kino.

derekherman avatar derekherman commented on May 24, 2024

I think the option Configure as a single-page app (rewrite all urls to /index.html)? should be set to Yes and then it would leave the config file as-is.

from kino.

beaufortfrancois avatar beaufortfrancois commented on May 24, 2024

Thank you @derekherman! You're right.
Here's the PR: #159

from kino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.