Code Monkey home page Code Monkey logo

developer.chrome.com's People

Contributors

aaronforinton avatar agektmr avatar amysteam avatar awfuchs avatar beaufortfrancois avatar devnook avatar heyawhite avatar ianstanion-google avatar ilyaspiridonov avatar jecfish avatar jeffposnick avatar johnrich85 avatar jpmedley avatar kevinkiklee avatar matthiasrohmer avatar maudnals avatar michaelsolati avatar mihajlija avatar nancymic2 avatar oliverdunk avatar petele avatar rachelandrew avatar robdodson avatar rowan-m avatar samdutton avatar samthor avatar simgobb avatar sofiayem avatar tomayac avatar tunetheweb avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

developer.chrome.com's Issues

Broken links on https://developer.chrome.com/docs/extensions/mv2/devtools/

Describe the bug
This docs page has several broken links (404's):
https://developer.chrome.com/docs/extensions/mv2/devtools/

To Reproduce
Steps to reproduce the behavior:

Missing type annotations for some properties of API reference

Fatnav: long categories overflow

Apps/Extensions/Native categories all have large lists of category/pages. They overflow the fatnav. I need to make things smaller and figure out a way to better hand large categories.

Article: needs TOC

The "sidebar" internal-to-the-page navigation (TOC) for articles needs more work. It's supposed to open and close as people scroll down the page. And be pinned to the sidebar (on wider screens) as the user scrolls.

There's also more to be worked out around how it works on narrow screens.

chrome.printerprovider page does not display it's information properly

The chrome.printerprovider event don't display the event passed parameters making it unusable.
When callback function are used there is no description of the expected input parameter nor number of parameter.

I had to look at the Google search cached page (old page) to get event desciption.

I don't look at other API but it seems the issue is for all event.

Add icon art once the files are delivered by Huge

In the designs there are icons highlighting content in two places:

Home page:
home

Pillar page:
pillar

I've asked August Navarro from Huge for the original artwork for these graphics, but I haven't heard back from him yet. ([email protected])

Zhu Zhu, designer at Google, has created a mockup showing how she wants these graphics to be grey instead of blue.

screen shot 2013-11-25 at 4 32 12 pm

Zhu created a photoshop file, and we have the original photoshop file from Huge. But neither of these are vector files. We could create @1x png/gif images from the PSDs, (or make a sprite if we decide we want these to be background styles). But we can't make SVG files or an icon font without first getting originals from Huge, (nor make @2x retina ready images, since the PSDs are too low of resolution).

Hopefully once August is back from vacation we'll hear from him. Meanwhile I wanted to open an issue to note that these icons still need to be added.

Article: TOC should not be embedded in article for mobile view

Instead, the mobile view kills the TOC and has expanders on the actual content sections:

screen shot 2013-12-05 at 12 51 38 pm

@Meggin and I chatted. We're going to partition articles content into <section> tags. <h2> headings signify a new section. The "related content" section still appears at the bottom of the article.

Style the "warnings" and "notes"

The files from Huge show two stylings — one for notes and another for warnings or important notes. One is a tooltip style pop-up, the other is red text inline to the page.

I'm not sure how these are handled in the current CMS, or what the resulting HTML is.

Both need to be styled.

New site is missing API version information

I found there is no "Since Chrome version" in new api reference. In the past, there are many statement say like "Since Chrome 48". This information is useful for compatibility. Developers can detect features or set "minimum_chrome_version" in manifest.

footer background color

There a couple different things going on with the footer background.

The PSDs from Huge have two different treatments:

5283cec22cdcae43fc13ae0a

and

5283cef22cdcae43fc13ae19

The home and pillar pages have white-background footers. The article page has a solid grey color (even throughout).

On Chrome.com, every page has the same footer treatment — a lint great box that's actually a gradient that fades from a slightly-darker grey at the top of the box to an almost white color at the bottom of the box.

download

It seems to me all developer.chrome.com pages should have the same grey-gradient treatment as chrome.com.

Thoughts?

Typo in the readme

In the source paragraph there's "The source code to devleoper.chrome.com will launch after Chrome Dev Summit 2020."

I've created a PR that fixes the typo

Images in the images dir?

Hey,
Are we using any of the images in the directory at static/images? There are a lot in there. I'm assuming that's reference stuff from the Chrome.com dump. I'd like to move them away, so that it's obvious what are real images for this new work, and what's not.

Is there anything in there that you are using @ebidel ?

Consider where to introduce animation

Chrome.com has a lot of animated bits here and there, which enhance the presentation of the content. The folks at Huge focused on designing flat files in Illustrator and Photoshop, and never mentioned interactivity or motion. I don't think it's something they think about in their process. I believe, however, that since the web is not a printed brochure, motion and animation should be considered. And it would help to match the branding between the two sites.

I added a simple transform to link hovers. It matches a hover transform from chrome.com.

I don't think it makes sense to translate all the animation directly from the product website to the documentation website, since people return to the documentation site over & over, instead of visiting it once. Chrome.com's animation creates the feeling of a product unveiling — aka, "Here is Chrome! Look at this amazing product. Ta da! " Too much of that kind of thing would get on developers' nerves. "Here's the documentation you are looking for!... Ta Da!" is not the right tone.

Some simple transformations could make for nice touches, however. Things that happen quickly, and don't require anyone to wait for the content to be ready to use. Things that feel like subtle enhancements, not obstacles. Things that do match the branding, and simply let people know, hey this is a modern website using some of the latest techniques, because we are smart and build things with new technology.

I thought I'd open a discussion.

How much is the existing article markup going to remain the same?

As noted in another issue, I'm looking at the markup of the main content on this page: https://developers.google.com/chrome-developer-tools/docs/elements

Hm.

The <p> tags aren't nested properly in places. And both <b> and <strong> are being used in ways that aren't quite correct semantically. And images are marked-up with extraneous divs that we don't need.

How much will there be a chance to clean stuff like this up in the conversion? Or is this markup something consistent and universal that we should support with the new CSS, and just live with? Or is it something that we'll have to live with, but that isn't standardized across pages / not something to "support" because there are a lot of little inconsistent errors created manually over years…

Ah, life. And pickiness.

Relative image paths in CSS

Change urls in styles to use ../images/* instead of /static/images/*, to proper allow testing in the appengine server where the root dir can be /_patch/, for example.

History api added twice in the same page

Describe the bug
The website contains the same api link twice for history API

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

mega-menu styling

The megamenu should be styled to have the background color, borders, and drop-shadows of chrome.com:

chrome web store for education 2013-11-13 14-54-16

Sorry, Eric I didn't know you didn't know that the wireframe pdfs were just wireframes. And not how it should look visually.

We should be able to just grab the CSS from the chrome.com stash. I was going to work on this, but since you are All Things Mega-Menu, I figured I should just drop a note about it and leave it to you.

Linked assets on /docs/webstore/branding are missing

Describe the bug
Linked assets on /docs/webstore/branding are missing

To Reproduce
Steps to reproduce the behavior:

  1. Visit https://developer.chrome.com/docs/webstore/branding/
  2. Find the table of images assets
  3. Attempt to download an image

All asset links 404.

Expected behavior
The linked assets should either load in your browser or be downloaded directly to disk.

Screenshots
The below image shows the table of image assets in question.

Screen Shot 2020-12-08 at 2 48 32 PM

Additional context
The missing image assets can be found here: https://github.com/GoogleChrome/webstore-docs/tree/master/images

Article: some links in TOC are buggy

An empty TOC top level (no children) doesn't allow clicking on it to jump to a top level header. Currently, there are many one-level-depth docs.

Removing the "toplevel" class from empty headers works, but the difference in style between same level headers with (bold) and without children (soft gray) looks weird.

Body text size

So on chrome.com, the default text size is 13px.

google chrome - signing in 2013-11-12 19-17-34

And this size is what's specified in the designs from Huge.

But I think it's way too small.

Especially on screens where the pixel density is really tight (like the iPad mini, for example), the text ends up being very small.

As I roam around studying designs from amazing people who know typography at a deep, deep level, 16px has become a favorite default. It works well on a wide range of screen densities — not too big and not too small.

Of course, there's an accessibility issue here as well as a readability issue. People will significantly-impaired vision will have other solutions — I don't mean them. I'm thinking of the large percentage of the population who's older than 35 and can't easily read tiny, tiny text anymore. 13px on the web is just so small.

Items laid-out using Google's grid need gutters between columns

There are items on the home page and on the bottom of the pillar page that are setup as three boxes across (for wider screens). There are no gutters on these columns. I'm not sure if there used to be gutters, and I messed up the code that created such gutters, or if they never had gutters. I still just don't get how this grid system works when it's at its best, so @ebidel I'd like to leave this task for you — to fix this.

Screenshots and other images should have alt text

I'm using this page as an example of content as we work: https://developers.google.com/chrome-developer-tools/docs/elements. So I've been looking at the HTML of the page.

None of the images have alt text. They really should.

This isn't a development bug, it's a content workflow / CMS tooling / culture issue. Something to talk about. There are a lot of people who are both professional developers and screen reader users. I personally know two. I'd love to see Google's Chrome Developer documentation include them.

ie9 support? re: flexbox

I'm about to re-implement the pillar page layout using Flexbox instead of the current floats. Trying to set the height of these boxes to a fixed amount to work across a variety of widths with different content is a crazy fox chase that I'd rather not start. Flexbox will be faster than writing a bunch of tweaks to the height across a dozen of media queries (what I've done in the past for situations like this) — and it will result in a much better layout.

I'm thinking of implement Chris Coyier's mix of old and new flex box syntax to cover most browsers: http://css-tricks.com/using-flexbox/

The only holdout with that technique is IE9. We aren't supporting IE 6,7,8, right? Do we need to worry about IE9? I can easily add a conditional class on the html element and move the current layout CSS into an IE9-only stylesheet (with giantly-tall heights on each box). Or we can leave this page with no layout for the seven ie9 users. People will still see the content, it'll just be in a tall, thin single column.

Thoughts @ebidel ?

Internal links in new extensions docs

Some links need to be updated e.g. links to the overview of 'message passing' are currently incorrect as https://developer.chrome.com/docs/messaging/ -> should be https://developer.chrome.com/docs/extensions/mv2/messaging/

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.