The SpannerCommitTimestampSqlType is no longer a SqlType and the documentation is not up to date with the latest implementation.

The following release PRs may have failed:

• #75

Add sample for collection mapping and best practices.

Add a sample that shows how an application can execute Partitioned DML by unwrapping the underlying Spanner connection.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/PartitionedDmlSample.cs

Set up a framework for creating and running samples.

Add tests for single table inheritance tables, including:

• Mutations
• Commit timestamps
• Discriminator column

NHibernate allows users to automatically generate/update/delete the data model from the entity model. This feature should only generate valid Spanner DDL statements. This feature is currently not tested by the driver implementation.

Add a sample for the SpannerSchemaUpdater

The Cloud Spanner NHibernate dialect currently supports DEFAULT column values using a client side implementation. Cloud Spanner now however supports DEFAULT column values, and the NHibernate dialect should use this instead when possible. A column with a default value can't be a commit timestamp column. The implementation for this must therefore remain client side in the dialect implementation.

See also https://cloud.google.com/spanner/docs/reference/standard-sql/data-definition-language#description_2

The following release PRs may have failed:

• #121 - The release job failed -- check the build log.

Optimistic concurrency control is normally done by NHibernate by adding a WHERE Id=:id AND Version=:version to a DML statement. It is not possible to add such a where clause when using mutations for updating/deleting a record. Instead, NHibernate should in that case execute a SELECT 1 FROM <table> WHERE Id=:id AND Version=:version in the same read/write transaction as where the mutation will be applied. This will ensure that:

1. If the query actually returns a row, we know for sure that the condition holds (i.e. the version has not changed).
2. The row will be locked during the read/write transaction, which again means that we know for sure that the condition holds true until the transaction has committed.

The tests that verify the same behavior for Entity Framework can be found here:

1. https://github.com/googleapis/dotnet-spanner-entity-framework/blob/fdc22c1566be535ad7f6a167fe29ca2bc805a76b/Google.Cloud.EntityFrameworkCore.Spanner.Tests/EntityFrameworkUsingMutationsMockServerTests.cs#L304
2. https://github.com/googleapis/dotnet-spanner-entity-framework/blob/fdc22c1566be535ad7f6a167fe29ca2bc805a76b/Google.Cloud.EntityFrameworkCore.Spanner.Tests/EntityFrameworkUsingMutationsMockServerTests.cs#L392
3. https://github.com/googleapis/dotnet-spanner-entity-framework/blob/fdc22c1566be535ad7f6a167fe29ca2bc805a76b/Google.Cloud.EntityFrameworkCore.Spanner.IntegrationTests/VersioningTests/VersioningTests.cs#L23

The last point references integration tests that will automatically use mutations instead of DML. That is different in Entity Framework and NHibernate:

1. Entity Framework will automatically use mutations when no explicit transaction is started. This is the case for the above mentioned integration tests.
2. NHibernate never uses mutations unless it is explicitly told to do so. You can instruct NHibernate to use mutations for a transaction by calling BeginTransaction(MutationUsage.Always). See this test case for an example.

Transactions can use both DML and mutations. Commit timestamps can be automatically written when using DML. That is currently not supported for mutations.

The following release PRs may have failed:

• #75

The Connection API retries explicit transactions using a checksum strategy if these are aborted by Cloud Spanner. For single (Batch) DML statements the checksum strategy is overkill, and instead the underlying transactions should use the Spanner data client SpannerRetriableTransaction version.

Add a sample that shows how to work with the TIMESTAMP data type, and how the DateTime Clr type is mapped to this data type (and not to the DATE data type).

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/TimestampSample.cs

The Spanner NHibernate driver contains two different SpannerEntityPersister instances. This is probably confusing for users, and it is better to merge the two into one and instruct all users to always use the only SpannerEntityPersister.

Add a sample that shows how to work with interleaved tables, and how these can be mapped as many-to-one relationships.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/InterleavedTableSample.cs

The following configuration should be considered for inclusion in the default settings for the dialect:

• BatchVersionedData: Setting this to default true will ensure that updates/deletes that include a version check will also be batched (i.e. use BatchDML or Mutations)
• UseComments: Setting this to default true will make it less likely that anyone makes a misconfiguration when they want to use query hints. Query hints are included in a query by first adding them as a comment, and not having comments enabled will cause hints not to be generated.
• WrapResultSets: This will ensure calls to ResultSet.GetOrdinal will be cached.

EDIT:

• UseComments: This should not be enabled by default, as comments are only necessary for query hints. Query hints also require a query interceptor to be added to the configuration (and interceptors cannot be added to the default configuration), which means that users will always need to take action to use query hints. Requiring users to add two items to the configuration instead of only one does not make a very big difference, while setting UseComments to true by default would mean that the dialect would always generate additional SQL comments for each statement that would not be needed in most cases.
• WrapResultSets: This option has been tested with the benchmarks, and did not make any measurable difference. Adding it to the default configuration is therefore not necessary.

Add a sample that shows how to execute an NHibernate query using Linq.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/QueryWithLinqSample.cs

The current SpannerDialect implementation returns an instance of PostgreSQL metadata. This should be a custom implementation specifically for Cloud Spanner.

Add a sample to show how to use the Spanner DATE data type.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/DateSample.cs

JOIN hints can (probably) be supported in the same way as TABLE hints are currently supported.

Add a sample that shows how to work with mutations and what the limitations are.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/MutationUsageSample.cs

Add a sample that shows how to map all Spanner data types in NHibernate.

The Spanner driver currently has two custom entity persisters:

• One that supports generating mutations
• One that supports fixed literal values, for example for PENDING_COMMIT_TIMESTAMP()

These entity persisters should be merged into one general SpannerSingleTableEntityPersister.

Add a sample that shows how to use query hints with NHibernate. The example should show this for:

• HQL
• Linq
• Criteria API

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/QueryHintSample.cs

Add a sample for the SpannerSchemaExporter

Add a sample that shows how to work with a generated column in NHibernate.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/GeneratedColumnSample.cs

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency benchmarkdotnet to v0.13.2
• chore(deps): update dependency docker.dotnet to v3.125.12
• chore(deps): update dependency gcp-releasetool to v1.8.8
• chore(deps): update dependency google-auth to v2.11.1
• chore(deps): update dependency keyring to v23.9.3
• chore(deps): update dependency microsoft.net.test.sdk to v17.3.1
• chore(deps): update dependency nhibernate to v5.3.13
• chore(deps): update dependency pyjwt to v2.5.0
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update dependency certifi to v2022.9.14
• chore(deps): update dependency click to v8.1.3
• chore(deps): update dependency google.cloud.spanner.data to v4
• chore(deps): update dependency protobuf to v4

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Benchmark NHibernate using the same scenarios as for EF Core.

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> Google.Cloud.Spanner.Data.SpannerException: The operation was aborted.
 ---> Grpc.Core.RpcException: Status(StatusCode="Aborted", Detail="Transaction aborted. Database schema probably changed during transaction, retry may succeed.", DebugException="Grpc.Core.Internal.CoreErrorDetailException: {"created":"@1640177671.725563766","description":"Error received from peer ipv4:108.177.111.95:443","file":"/var/local/git/grpc/src/core/lib/surface/call.cc","file_line":1067,"grpc_message":"Transaction aborted. Database schema probably changed during transaction, retry may succeed.","grpc_status":10}")
   at Grpc.Gcp.GcpCallInvoker.<>c__DisplayClass27_0`2.<<AsyncUnaryCall>g__PostProcessPropagateResult|3>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Google.Api.Gax.Grpc.ApiCallRetryExtensions.<>c__DisplayClass0_0`2.<<WithRetry>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Google.Cloud.Spanner.V1.Internal.ExecuteHelper.WithSessionExpiryChecking[T](Task`1 task, Session session)
   at Google.Cloud.Spanner.V1.PooledSession.RecordSuccessAndExpiredSessions[T](Task`1 task)
   at Google.Cloud.Spanner.V1.PooledSession.CommitAsync(CommitRequest request, CallSettings callSettings)
   at Google.Cloud.Spanner.Data.SpannerTransaction.<>c__DisplayClass53_0.<<CommitAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Google.Cloud.Spanner.Data.ExecuteHelper.WithErrorTranslationAndProfiling[T](Func`1 t, String name, Logger logger)
   --- End of inner exception stack trace ---
   at Google.Cloud.Spanner.Data.ExecuteHelper.WithErrorTranslationAndProfiling[T](Func`1 t, String name, Logger logger)
   at Google.Api.Gax.TaskExtensions.WaitWithUnwrappedExceptions(Task task)
   at Google.Cloud.Spanner.Data.SpannerTransaction.Commit(DateTime& timestamp)
   at Google.Cloud.Spanner.NHibernate.Benchmarks.SpannerNHibernateBenchmarks.SelectMultipleSingersInReadWriteTransactionSpanner() in /home/koloite/dotnet-spanner-nhibernate/Google.Cloud.Spanner.NHibernate.Benchmarks/SpannerNHibernateBenchmarks.cs:line 343
   at BenchmarkDotNet.Autogenerated.Runnable_12.WorkloadActionNoUnroll(Int64 invokeCount) in /home/koloite/dotnet-spanner-nhibernate/Google.Cloud.Spanner.NHibernate.Benchmarks/bin/Debug/netcoreapp3.1/3d391572-0dcf-44f0-b8ae-1de4d6327430/3d391572-0dcf-44f0-b8ae-1de4d6327430.notcs:line 9287
   at BenchmarkDotNet.Engines.Engine.RunIteration(IterationData data)
   at BenchmarkDotNet.Engines.EngineStage.RunIteration(IterationMode mode, IterationStage stage, Int32 index, Int64 invokeCount, Int32 unrollFactor)
   at BenchmarkDotNet.Engines.EngineActualStage.RunAuto(Int64 invokeCount, IterationMode iterationMode, Int32 unrollFactor)
   at BenchmarkDotNet.Engines.EngineActualStage.Run(Int64 invokeCount, IterationMode iterationMode, Boolean runAuto, Int32 unrollFactor, Boolean forceSpecific)
   at BenchmarkDotNet.Engines.EngineActualStage.RunWorkload(Int64 invokeCount, Int32 unrollFactor, Boolean forceSpecific)
   at BenchmarkDotNet.Engines.Engine.Run()
   at BenchmarkDotNet.Autogenerated.Runnable_12.Run(IHost host, String benchmarkName) in /home/koloite/dotnet-spanner-nhibernate/Google.Cloud.Spanner.NHibernate.Benchmarks/bin/Debug/netcoreapp3.1/3d391572-0dcf-44f0-b8ae-1de4d6327430/3d391572-0dcf-44f0-b8ae-1de4d6327430.notcs:line 8968
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at BenchmarkDotNet.Autogenerated.UniqueProgramName.AfterAssemblyLoadingAttached(String[] args) in /home/koloite/dotnet-spanner-nhibernate/Google.Cloud.Spanner.NHibernate.Benchmarks/bin/Debug/netcoreapp3.1/3d391572-0dcf-44f0-b8ae-1de4d6327430/3d391572-0dcf-44f0-b8ae-1de4d6327430.notcs:line 66

Add a sample that shows how to execute a single stale read query using NHibernate.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/StaleReadSample.cs

Add a sample that shows how to use a read-only transaction in NHibernate.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/ReadOnlyTransactionSample.cs

Users must use the SpannerRetriableConnection and not SpannerConnection with the NHibernate driver. This is automatically done when the users allow the driver to create the connection, but when supplying a connection manually, the user is responsible for supplying the correct type of connection.

Add a sample that shows how to assign the commit timestamp of a transaction to a property of an entity.

See also https://github.com/googleapis/dotnet-spanner-entity-framework/blob/main/Google.Cloud.EntityFrameworkCore.Spanner.Samples/Snippets/CommitTimestampSample.cs

Add a sample that shows how to use the ARRAY data type for entity properties.

Policy Bot found one or more issues with this repository.

• Default branch is 'main'
• Branch protection is enabled
• Renovate bot is enabled
• Merge commits disabled
• There is a CODEOWNERS file
• There is a valid LICENSE.md
• There is a CODE_OF_CONDUCT.md
• There is a CONTRIBUTING.md
• There is a SECURITY.md

Add tests for collection mappings for both OneToMany and ManyToMany. Test both mutations and DML.