google / pepper.js Goto Github PK

A fresh clone of this repo against pepper_canary doesn't build properly under examples, as it is looking for an alarms_dev.cc file that doesn't exist.

It looks like in canary the ppapi_cpp files have been moved around, but simply changing the SOURCES variable in examples/ppapi_cpp/Makefile to match the current contents of $NACL_SDK_ROOT/src/ppapi_cpp/*.cc fixes the problem and the examples build properly.

Once those have been fixed, the tests directory fails with missing ppb_testing_dev.h header, which I wasn't able to as easily correct.

pepper.js doesn't seem to be getting the love and attention that it deserves from the Native Client team (1 developer, no commits for 2 months).

This project needs to folded into the main Native Client SDK and polished. It needs to become part of the "standard way". A pnacl solution by itself is a tough sell. A pnacl + fallback to emscripten solution is far easier to justify

If you try to make the Pepper.js files on MS Windows you get a build error when trying to compile the release version of emscripten. The debug version seems to work properly.

make TOOLCHAIN=emscripten CONFIG=Release

It appears to be a problem with copying finished .js file uses 'cp' should be 'copy'?

The link to the Emscripten SDK on the Getting Started wiki page looks like it is broken. It points to this page:

https://github.com/kripken/emscripten/wiki/Emscripten-SDK

which no longer exists. It should probably point to this page instead:

http://kripken.github.io/emscripten-site/docs/getting_started/downloads.html

It looks like in tools/nacl_emscripten.mk there is a mention of emcc's --js-library option, however, I don't think I see usage of that - seems like --pre-js is used to include the code?

In general, a JS library is preferable as it lets the compiler add only the necessary parts of code during compile time, and also when the compiler knows which functions are actually present (JS libraries allow that), the compiler does not generate unnecessary stubs for external calls, and can integrate with things like closure compiler.