Reading multiple extensions of the same message type with different name about openrtb HOT 4 CLOSED

This one will take some time — the JSON extension API is already the part of this library I'm less happy about. Good that for now you have a workaround, meanwhile I'm lookingo into a real improvement for this API instead of just adding another special case.

from openrtb.

Ok, the latest code on master should fix this last limitation, also it does the big revamp of the JSON extension API that I'd been putting off for too long. This required breaking changes but not too bad and the new code is simpler–most readers will lose one generic parameter so you don't need to use a dummy ..., Message.Builder>; others will have to change the base class and lose the first parameter in the read() method. Some work too for easier development like proper abstract methods and more error handling and logging.

I'm afraid testing this can be difficult before the next Open Bidder is released because the code in master for these libraries include other changes (even a rare breaking change in the AdX protocol), but there are new unit tests that reproduce your use case so hopefully this will solve the problem.

from openrtb.

Thank you for looking into this. I'll test this in the context of the next OB release!

from openrtb.

Hi, just for completeness' sake - my original work-around did not have the intended effect. I just settled for something like this:

public class EventExtensionReader extends OpenRtbJsonExtReader<Bid.Builder, Event.Builder> {

    private String keyName;

    public EventExtensionReader(GeneratedExtension<?, ?> key) {
        super(key);
        this.keyName = key.getDescriptor().getName();
    }

    @Override
    protected void read(Bid.Builder msg, Event.Builder ext, JsonParser par) throws IOException {
        String fieldName = getCurrentName(par);
        if (keyName.equals(fieldName) == false) {
            return;
        }
        Type type = Type.valueOf(getCurrentName(par).toUpperCase());
        EventUtils.read(ext, type, par);
    }

}

The only drawback of this solution is that it requires a different reader instance for each key type - click, impression in my case. The read method returns early if the field name does not match the key. I can live with that.

from openrtb.