Comments (2)
Hello @sevebisogni
Can you please explain why this was closed? And how to get around the above discrepancies between the Proto files and IAB specification?
from openrtb.
Hi, sorry for not noticing this way back before the issue was closed. The mapping of bool fields has been detailed elsewhere, but probably only in the openrtb discussion groups and other documents many years ago. But the TLDR is that this proto is biased for strong typing, this includes not only bools but also enums instead of ints everywhere like in the spec.
Some Protobuf libraries, including Google's public Protobuf project, have JSON serialization functionality that have an option to serialize bools to 1/0 and deserializing those back to bools. I am no specifically familiar with jsonpb but maybe there's an option like that too, by the way many JSON libraries in general support this option, for example in Jackson (the most popular JSON API for Java) you can do that with @JsonFormat(shape = Shape.NUMBER)
. This is a very common issue in JSON because 1/0 take a lot less space than true/false, but using ints for fields that are semantically booleans is a very poor choice for any static-typed language.
The proto is perfectly compatible with the spec if you have a Proto/JSON library that can use the correct on-wire representation of 0/1. The spec only describes the on-wire messages, it doesn't describe an API.
from openrtb.
Related Issues (20)
- Native Data Asset Type >= 500 throws error during deserialization. HOT 1
- When enum name is stripped and label is PascalCased (Iab11), this value label conflicts with IAB1_1 HOT 7
- Extension Json Serialization Documentation Lacking HOT 2
- Version Specific BidRequest Writers HOT 4
- build DSP
- Wrong default value for deal auction type. HOT 3
- Handling 500+ DataAssetType Values HOT 7
- Fix miniumum JDK version in README.md HOT 1
- valid adm content and dynamic banners.
- Cannot find VideoBidResponseProtocol when running example HOT 1
- Error in Android 6.0.1
- Suppot of adm_native field in Bid Response HOT 2
- Missing Field Values for native bid request
- Failed to generate Golang source file for openrtb.proto using proto3 HOT 1
- Cannot import specific class in Eclipse HOT 4
- How to add a missing field from the OpenRTB spec? HOT 1
- protoc warnings HOT 1
- Unable to use extensions 'ext'
- How to create BidResponse and send it in JSON format HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb.