Code Monkey home page Code Monkey logo

Comments (4)

Harwayne avatar Harwayne commented on June 11, 2024 1

Doesn't this correspond to filtering out 2xx responses and summing the values in a group by clause containing all the labels apart from response_code/response_code_class?

I don't think so. The only events that would affect reply-event-count are those that already are in the 2xx status code of event-count, because the only way a reply is even attempted is if the request to the subscriber succeeds and it replies with an event.

Essentially, the flow of the event is something like:

  1. An event is sent to the Broker and goes to this Trigger.
  2. This Trigger sends the event to the subscriber.
  3. The subscriber responds with a 200 and a cloud event.
    • This is added to the event-count and dispatch-latency metrics.
  4. The Trigger sends the replied event to the reply address.
  5. The reply address responds with some status code.
    • This is added to the reply-event-count metric, suggested in this issue (name is just an example, not a real suggestion).

from knative-gcp.

bharattkukreja avatar bharattkukreja commented on June 11, 2024

Doesn't this correspond to filtering out 2xx responses and summing the values in a group by clause containing all the labels apart from response_code/response_code_class?

from knative-gcp.

bharattkukreja avatar bharattkukreja commented on June 11, 2024

Created a similar issue in knative/eventing based on Adam's suggestion that it could be worthwhile exposing these metrics in OSS: knative/eventing#4831

from knative-gcp.

github-actions avatar github-actions commented on June 11, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

from knative-gcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.