Code Monkey home page Code Monkey logo

Comments (1)

zhongduo avatar zhongduo commented on June 10, 2024

This is caused by both gcp broker and knative brokers such as mtbroker are trying to reconcile the Triggers without associated broker. The trigger status will be updated constantly, which causes more reconciliation. After removing the MT broker controller, it is working as expected.

I think the problem is larger than knative-gcp, the root cause is all the brokers might want to reconcile triggers without a broker, but if no one reconcile it, it can not have the right "BrokerDoesNotExist" status. So I think the proper way is to

  1. have a set of predefined error status in knative eventing which can be called by any brokers multiple times without really changing the status, eg don't commit the same error. Or this logic can be just in knative eventing controller.
  2. when the trigger does not have associated broker, no broker-specific status can be set

from knative-gcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.