Comments (5)
liutikas
commented on July 19, 2024
1
@jjohannes since you added the Gradle module metadata support in the first place
from guava.
liutikas
commented on July 19, 2024
What would work better in this case is to use available-at instead of files
If guava-32.1.3-android.module instead has this:
{
"name": "jreApiElements",
"attributes": {
"org.gradle.category": "library",
"org.gradle.dependency.bundling": "external",
"org.gradle.jvm.version": "8",
"org.gradle.jvm.environment": "standard-jvm",
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-api"
},
"available-at": {
"url": "../32.1.3-jre/guava-32.1.3-jre.module",
"group": "com.google.guava",
"module": "guava",
"version": "32.1.3-jre"
}
},
{
"name": "jreRuntimeElements",
"attributes": {
"org.gradle.category": "library",
"org.gradle.dependency.bundling": "external",
"org.gradle.jvm.version": "8",
"org.gradle.jvm.environment": "standard-jvm",
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-runtime"
},
"available-at": {
"url": "../32.1.3-jre/guava-32.1.3-jre.module",
"group": "com.google.guava",
"module": "guava",
"version": "32.1.3-jre"
}
}
signature verification succeeds.
it also reduces redundancy of declared dependencies.
from guava.
liutikas
commented on July 19, 2024
Note that available-at matches how Kotlin Multiplatform artifacts handle disambiguation in gradle module metadata.
See https://repo1.maven.org/maven2/com/squareup/okio/okio/3.9.0/okio-3.9.0.module as an example
from guava.
jjohannes
commented on July 19, 2024
Thank you for investigating and sharing @liutikas.
I am afraid that available-at cannot be used in this case.
The difference between how Guava does variants compared to how it is done elsewhere (e.g. Kotlin Multiplatform) is that Guava uses different versions of the same component to represent the variants.
(1) In Guava you have
com/google/guava // group
└── guava // name
├── 33.1.0-android // version (!)
│ └── guava-33.1.0-android.jar
└── 33.1.0-jre // version (!)
└── guava-33.1.0-jre.jar
(2) If Guava would represent the android variant as classified Jar
Ideally, you would use just multiple artifacts with classifiers. That what I would do for a Java library today if I would publish it with two variants for "jre" and "android". (And the metadata we have now is very close to it, just that it hast to point into the other version folder – ../32.1.0-jre/ – to find the other variant Jar file.)
com/google/guava // group
└── guava // name
└── 33.1.0 // version
└── guava-33.1.0.jar // standard/fallback without classifier (jre)
└── guava-33.1.0-android.jar
(3) If Guava would represent its variants as Kotlin Multiplatform does
If there is a specific reason to have each variant in a separate component (like in Kotlin Multiplatform) you can do that and use available-at to "connect" these components as "variants of one main component":
com/google/guava // group
├── guava // name (main component)
│ └── 33.1.0 // version
│ └── guava-33.1.0.module // only metadata (no Jar) with 'availbale-at'
│
├── guava-android // name (separate component that is also used as variant)
│ └── 33.1.0 // version
│ └── guava-android-33.1.0.jar
└── guava-jre // name (separate component that is also used as variant)
└── 33.1.0 // version
└── guava-jre-33.1.0.jar
I can still emphasize with why solution (1) was chosen years ago. It is "misusing" the version conflict resolution of the build tools to make sure that never both variants are selected together. Today, Gradle is "variant aware" and solution (2) would be better and the metadata we have tries to get to that as close as possible. (But even if it would be reinvented today, what about Maven which does not have such variant awareness? yet?)
In the current setup (1), we cannot use available-at, because it would point at another version of itself. Which is weird, because not both versions can be selected together. But in the available-at is treated as an edge between two nodes in the dependency graph. But these two nodes can not both exist. I haven't tried, but you might get an "invalid metadata" error directly, because the spec explicitly states that this is not possible here: https://github.com/gradle/gradle/blob/master/platforms/documentation/docs/src/docs/design/gradle-module-metadata-latest-specification.md#available-at-value
Note that the
group:modulecannot be the same as thegroup:moduleof the rootcomponentelement.
from guava.
liutikas
commented on July 19, 2024
If I add the following diff to https://github.com/liutikas/guava-signature-repro repro project
diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml
index 901027d..c611b39 100644
--- a/gradle/verification-metadata.xml
+++ b/gradle/verification-metadata.xml
@@ -500,5 +500,21 @@
<sha256 value="b51f8867c92b6a722499557fc3a1fdea77bdf9ef574722fe90ce436a29559454"/>
</artifact>
</component>
+ <component group="com.google.guava" name="guava" version="32.1.3-jre">
+ <artifact name="guava-32.1.3-jre.module">
+ <ignored-keys>
+ <ignored-key id="BDB5FA4FE719D787FB3D3197F6D4A1D411E9D1AE" />
+ </ignored-keys>
+ <sha256 value="e43870007081e972b73a57fe1ad840ed469290c47bb5d51dac5939756258064d"/>
+ </artifact>
+ </component>
+ <component group="com.google.guava" name="guava" version="32.1.3-android">
+ <artifact name="guava-32.1.3-android.module">
+ <ignored-keys>
+ <ignored-key id="BDB5FA4FE719D787FB3D3197F6D4A1D411E9D1AE" />
+ </ignored-keys>
+ <sha256 value="79b98e8056a24d271609ab9e9b8dc73da2dd3d980aadd9a85021ce3def21beee"/>
+ </artifact>
+ </component>
</components>
</verification-metadata>
diff --git a/lib/build.gradle.kts b/lib/build.gradle.kts
new file mode 100644
index 0000000..d261c86
--- /dev/null
+++ b/lib/build.gradle.kts
@@ -0,0 +1,7 @@
+plugins {
+ id("java-library")
+}
+
+dependencies {
+ implementation("com.google.guava:guava:32.1.3-android")
+}
\ No newline at end of file
diff --git a/lib/src/main/java/com/example/lib/MyClass.java b/lib/src/main/java/com/example/lib/MyClass.java
new file mode 100644
index 0000000..58f7288
--- /dev/null
+++ b/lib/src/main/java/com/example/lib/MyClass.java
@@ -0,0 +1,4 @@
+package com.example.lib;
+
+public class MyClass {
+}
\ No newline at end of file
diff --git a/settings.gradle.kts b/settings.gradle.kts
index 7e67774..a997ab2 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -14,6 +14,9 @@ pluginManagement {
dependencyResolutionManagement {
repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
repositories {
+ maven {
+ url = uri("/usr/local/google/home/aurimas/Code/androidx-main/prebuilts/androidx/external")
+ }
google()
mavenCentral()
}
@@ -21,4 +24,4 @@ dependencyResolutionManagement {
rootProject.name = "My Application"
include(":app")
-
\ No newline at end of file
+include(":lib")
and the local copy maven has the following diff
diff --git a/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.module b/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.module
index efc9b8ca6..6bb088cc4 100644
--- a/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.module
+++ b/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.module
@@ -164,68 +164,12 @@
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-api"
},
- "dependencies": [
- {
- "group": "com.google.guava",
- "module": "failureaccess",
- "version": {
- "requires": "1.0.1"
- }
- },
- {
- "group": "com.google.guava",
- "module": "listenablefuture",
- "version": {
- "requires": "9999.0-empty-to-avoid-conflict-with-guava"
- }
- },
- {
- "group": "com.google.code.findbugs",
- "module": "jsr305",
- "version": {
- "requires": "3.0.2"
- }
- },
- {
- "group": "org.checkerframework",
- "module": "checker-qual",
- "version": {
- "requires": "3.37.0"
- }
- },
- {
- "group": "com.google.errorprone",
- "module": "error_prone_annotations",
- "version": {
- "requires": "2.21.1"
- }
- },
- {
- "group": "com.google.j2objc",
- "module": "j2objc-annotations",
- "version": {
- "requires": "2.8"
- }
- }
- ],
- "files": [
- {
- "name": "guava-32.1.3-jre.jar",
- "url": "../32.1.3-jre/guava-32.1.3-jre.jar"
- }
- ],
- "capabilities": [
- {
- "group": "com.google.guava",
- "name": "guava",
- "version": "32.1.3-android"
- },
- {
- "group": "com.google.collections",
- "name": "google-collections",
- "version": "32.1.3-android"
- }
- ]
+ "available-at": {
+ "url": "../32.1.3-jre/guava-32.1.3-jre.module",
+ "group": "com.google.guava",
+ "module": "guava",
+ "version": "32.1.3-jre"
+ }
},
{
"name": "jreRuntimeElements",
@@ -237,61 +181,12 @@
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-runtime"
},
- "dependencies": [
- {
- "group": "com.google.guava",
- "module": "failureaccess",
- "version": {
- "requires": "1.0.1"
- }
- },
- {
- "group": "com.google.guava",
- "module": "listenablefuture",
- "version": {
- "requires": "9999.0-empty-to-avoid-conflict-with-guava"
- }
- },
- {
- "group": "com.google.code.findbugs",
- "module": "jsr305",
- "version": {
- "requires": "3.0.2"
- }
- },
- {
- "group": "org.checkerframework",
- "module": "checker-qual",
- "version": {
- "requires": "3.37.0"
- }
- },
- {
- "group": "com.google.errorprone",
- "module": "error_prone_annotations",
- "version": {
- "requires": "2.21.1"
- }
- }
- ],
- "files": [
- {
- "name": "guava-32.1.3-jre.jar",
- "url": "../32.1.3-jre/guava-32.1.3-jre.jar"
- }
- ],
- "capabilities": [
- {
- "group": "com.google.guava",
- "name": "guava",
- "version": "32.1.3-android"
- },
- {
- "group": "com.google.collections",
- "name": "google-collections",
- "version": "32.1.3-android"
- }
- ]
+ "available-at": {
+ "url": "../32.1.3-jre/guava-32.1.3-jre.module",
+ "group": "com.google.guava",
+ "module": "guava",
+ "version": "32.1.3-jre"
+ }
}
]
}
diff --git a/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.module b/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.module
index 98d7896af..705815cc9 100644
--- a/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.module
+++ b/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.module
@@ -164,68 +164,12 @@
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-api"
},
- "dependencies": [
- {
- "group": "com.google.guava",
- "module": "failureaccess",
- "version": {
- "requires": "1.0.1"
- }
- },
- {
- "group": "com.google.guava",
- "module": "listenablefuture",
- "version": {
- "requires": "9999.0-empty-to-avoid-conflict-with-guava"
- }
- },
- {
- "group": "com.google.code.findbugs",
- "module": "jsr305",
- "version": {
- "requires": "3.0.2"
- }
- },
- {
- "group": "org.checkerframework",
- "module": "checker-qual",
- "version": {
- "requires": "3.37.0"
- }
- },
- {
- "group": "com.google.errorprone",
- "module": "error_prone_annotations",
- "version": {
- "requires": "2.21.1"
- }
- },
- {
- "group": "com.google.j2objc",
- "module": "j2objc-annotations",
- "version": {
- "requires": "2.8"
- }
- }
- ],
- "files": [
- {
- "name": "guava-32.1.3-android.jar",
- "url": "../32.1.3-android/guava-32.1.3-android.jar"
- }
- ],
- "capabilities": [
- {
- "group": "com.google.guava",
- "name": "guava",
- "version": "32.1.3-jre"
- },
- {
- "group": "com.google.collections",
- "name": "google-collections",
- "version": "32.1.3-jre"
- }
- ]
+ "available-at": {
+ "url": "../32.1.3-android/guava-32.1.3-android.module",
+ "group": "com.google.guava",
+ "module": "guava",
+ "version": "32.1.3-android"
+ }
},
{
"name": "androidRuntimeElements",
@@ -237,61 +181,12 @@
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-runtime"
},
- "dependencies": [
- {
- "group": "com.google.guava",
- "module": "failureaccess",
- "version": {
- "requires": "1.0.1"
- }
- },
- {
- "group": "com.google.guava",
- "module": "listenablefuture",
- "version": {
- "requires": "9999.0-empty-to-avoid-conflict-with-guava"
- }
- },
- {
- "group": "com.google.code.findbugs",
- "module": "jsr305",
- "version": {
- "requires": "3.0.2"
- }
- },
- {
- "group": "org.checkerframework",
- "module": "checker-qual",
- "version": {
- "requires": "3.37.0"
- }
- },
- {
- "group": "com.google.errorprone",
- "module": "error_prone_annotations",
- "version": {
- "requires": "2.21.1"
- }
- }
- ],
- "files": [
- {
- "name": "guava-32.1.3-android.jar",
- "url": "../32.1.3-android/guava-32.1.3-android.jar"
- }
- ],
- "capabilities": [
- {
- "group": "com.google.guava",
- "name": "guava",
- "version": "32.1.3-jre"
- },
- {
- "group": "com.google.collections",
- "name": "google-collections",
- "version": "32.1.3-jre"
- }
- ]
+ "available-at": {
+ "url": "../32.1.3-android/guava-32.1.3-android.module",
+ "group": "com.google.guava",
+ "module": "guava",
+ "version": "32.1.3-android"
+ }
}
]
}
both ./gradlew app:assembleDebug and ./gradlew lib:jar succeeds.
However, I do see that the spec does seem to forbid this :/
from guava.
Related Issues (20)
- Is `com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava` really necessary? HOT 2
- SmoothRateLimiter.SmoothBursty obtaining too many permits without failure HOT 1
- Certain versions of Guava on Maven central no longer working on Java 11 HOT 2
- guava-gwt should publish Gradle module metadata or somehow fix POM HOT 2
- java.lang.NoSuchMethodError: 'void com.google.common.base.Preconditions.checkState(boolean, java.lang.String, long) HOT 1
- `Suppliers.memoize()` thread pinning HOT 6
- Copying a filtered collection with ImmutableSet.copyOf() should require visiting each element only once HOT 1
- com.google.common.collect.Range#hasLowerBound determination error after deserialization HOT 7
- InternetDomainName.topPrivateDomain() throws exception for Amazonaws-Domain HOT 4
- Failing while building guava version v31.0.1 using mvn clean install HOT 3
- Make `Striped.custom` public HOT 3
- Improve `guava-android` Animal Sniffer compatibility testing for Java 8+ APIs HOT 1
- 2024年， 一元机场是不是跑路了？ HOT 1
- Add Duration support for CacheBuilder.expireAfterWrite like in other guava projects HOT 4
- class file for com.google.errorprone.annotations.CompatibleWith not found HOT 3
- Use GitHub Actions for most release automation HOT 1
- RateLimiter.tryAcquire blocks when it should not HOT 1
- Implement of RateLimiter.setRate can be simplified
- The PSL has been not been updated for over 3 months HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guava.