Comments (4)
Thanks a lot! Now it works as expected
from guava.
s3-eu-west-1.amazonaws.com is itself a public suffix, so it does not have a private domain.
from guava.
I see.
So it is not safe to do the following (as we currently do):
if (domainName.hasPublicSuffix()) {
return domainName.topPrivateDomain().toString();
}
?
We will have to check wheter domainName IS a pubic suffix not just whether it has one?
from guava.
If you want to know whether topPrivateDomain()
is safe to call, then the method to call is isUnderPublicSuffix()
, rather than hasPublicSuffix()
.
from guava.
Related Issues (20)
- Use Gradle module available-at tag instead of files for redirecting jre vs android consumers HOT 5
- Failing while building guava version v31.0.1 using mvn clean install HOT 3
- Make `Striped.custom` public HOT 3
- Improve `guava-android` Animal Sniffer compatibility testing for Java 8+ APIs HOT 2
- 2024年, 一元机场是不是跑路了? HOT 1
- Add Duration support for CacheBuilder.expireAfterWrite like in other guava projects HOT 4
- class file for com.google.errorprone.annotations.CompatibleWith not found HOT 3
- Use GitHub Actions for most release automation HOT 1
- RateLimiter.tryAcquire blocks when it should not HOT 1
- Implement of RateLimiter.setRate can be simplified
- The PSL has been not been updated for over 3 months HOT 4
- Suppliers.memoize should return a MemoizingSupplier with isMemoized() HOT 2
- Iterators: support transform() with JDK Function class HOT 2
- Bug - com.google.common.collect.ConcurrentHashMultiset.add(AtomicInteger, int) HOT 1
- SBOM Report for Infor( GRC product) HOT 3
- Bug - com.google.common.collect.ConcurrentHashMultiset.setCount(Object, int) HOT 2
- Bug - com.google.common.collect.ConcurrentHashMultiset.setCount(Object, int, int) HOT 1
- Bug - com.google.common.collect.Iterators.partition(Iterator<Object>, int) HOT 1
- Bug - com.google.common.collect.Iterators.paddedPartition(Iterator<Object>, int) HOT 1
- Bug - com.google.common.collect.Iterators.limit(Iterator<FilteringMode>, int) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guava.