Code Monkey home page Code Monkey logo

Comments (6)

peter-aglen avatar peter-aglen commented on September 24, 2024 1

Will do!

And just in case it's unclear; the above entry is the result of updating the Member privileges -> Repository creation setting in an enterprise organization. In this particular case we changed the setting from no privileges to Private.

The json string is copy-paste from the response to https://api.github.com/orgs/{org}/audit-log (via Postman).

from go-github.

WillAbides avatar WillAbides commented on September 24, 2024 1

There are a lot of inconsistencies between fields in audit log entries for different actions. IMO go-github shouldn't try to unmarshal any fields that aren't in the API definition because of inconsistencies like this.

from go-github.

peter-aglen avatar peter-aglen commented on September 24, 2024 1

Current response from tech support:

Thank you for reaching out. I agree this field is particularly confusing and I am also not sure about this boolean value. I have asked our engineers to take a second look and provide a definitive answer. Once I get further confirmation as to what this field is supposed to be, I will reach out to you.

from go-github.

gmlewis avatar gmlewis commented on September 24, 2024

Looking at this endpoint documentation: https://docs.github.com/en/enterprise-cloud@latest/rest/orgs/orgs?apiVersion=2022-11-28#get-the-audit-log-for-an-organization
I'm not seeing "permission" in the response schema at all, and "permission": true doesn't make any sense to me, so I'm really confused as to why you are getting that back in the response at all.

To get to the bottom of this, would you mind contacting the GitHub Tech Support team and ask them how this field should be treated? Feel free to point them to this issue. Then, we would appreciate it if you could please report back here what your findings are and how we should handle this field. Thank you!

from go-github.

peter-aglen avatar peter-aglen commented on September 24, 2024

New reply from tech support:

The field is supposed to represent whether members can create repositories with any visibility at the time the event was written.

So, not really a reply at all.

This is a major issue on our side. Do you by any chance have an ETA for the fix?

from go-github.

gmlewis avatar gmlewis commented on September 24, 2024

This is a major issue on our side. Do you by any chance have an ETA for the fix?

You could speed the process along by reviewing the proposed fix: #3017.
I need a second LGTM+Approval in order to merge.

from go-github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.