Comments (5)
This was implemented in #1907.
Can you give an example of how you would use it if it were exported?
Alternatively, feel free to write up a PR showing your use case as a new unit test and we can take a look at it.
from go-github.
@gmlewis thanks for the qr, let me validate because it may have been the github changes 3 days ago switching the message
from go-github.
OK, cool.
Also, I should have mentioned that the original problem that was trying to be solved was #1899 which would be great if you could take a look at when you have a moment.
from go-github.
@gmlewis took a look -- I do think the problem remains with it not being exported.
Based on review of the code, the github client will not make the extra call if the primary rate limit has been exceeded. Therefore, any RoundTrip rate limiting logic defined in the go-github rate limiter, or any other custom client, will NOT be reached.
It would be awesome to expose this, I'm happy too.
LMK what you think
Line 631 in 75644ea
I do not have the scope to confirm this locally FYI
from go-github.
So the gist you pointed me to appears to be extremely old and doesn't even contain checkSecondaryRateLimitBeforeDo
.
There also appears to be no difference to checkRateLimitBeforeDo
, so I'm not sure what I'm looking at.
If you want to make a PR based on the current top-of-trunk, that would be fine, and it should be much easier to compare.
from go-github.
Related Issues (20)
- Update deprecated endpoints in github/action_variables.go HOT 4
- `omitempty` tag on `InstallationAccessTokenOptions.Repositories` masking functionality of GitHub API HOT 11
- `NewTeam` missing `notification_setting` field HOT 1
- feat: Add an option to wait for primary rate limit reset and retry instead of erroring out HOT 7
- Username is required when using fine-grained vs classic PAT (personal access token) for PlainClone operation
- LIst of issue comments do not collect the comment which was added during the creation of the PR. HOT 6
- Use enums for the action field in GitHub Webhooks HOT 4
- Can't remove repository ruleset's every Bypass Actors because of serialization issue HOT 4
- Support new REST API endpoint that evaluates if private vulnerability reporting is enabled HOT 4
- Webhook MemberEvent Type is Missing Changes Object
- Bug: Issues.ListByRepo Repository field is always `nil` HOT 5
- `ListRunnersOption` change omits consideration of Enterprise Runner HOT 4
- Add support for CommitID, InReplyTo, and SubjectType to DraftReviewComment HOT 1
- Support for merge queues. HOT 3
- Bug: GetArchiveLink returns a status code 200, not 302, when link is requested with an installation token rather than personal/bearer token HOT 3
- WorkflowRun struct does not include `path` property HOT 1
- Proposal: Add GitHub App Token and Installation Token Source Functionality HOT 6
- GetEnterpriseRunner method appears to be missing HOT 1
- RepositoryPermissionLevel is missing role_name
- Space being stripped from Workflow Run, Job, and Step Names HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-github.