Comments (4)
@mozzy11 adding more comments made on slack
one minor issue
we don't need to define a default value for the parquet out put file path here,like it's done in batch here
since for now ,syncing to a Fhir Sink depends on whether the parquet out put file path is empty .
That means if i want to sync to a fhir sink , i simply dont pass the --fileParquetPath in the commandline params ..by default it defaults to null hence can sync to a fhir sink .the same way it is done in batch Mode
another minor issue
for uniformity through all the three sub-modules,
we should include the path as part of the base server url ,so this --openmrsServerUrl arg should default to "http://localhost:8099/openmrs" not "http://localhost:8099"
and also this --openmrsfhirBaseEndpoint arg should default to "/ws/fhir2/R4" not "/openmrs/ws/fhir2/R4" as its done here (edited)
from fhir-data-pipes.
oh ya sure , that was a minor quick fix ,for the way things are .
from fhir-data-pipes.
from fhir-data-pipes.
Thanks @kimaina for the review
from fhir-data-pipes.
Related Issues (20)
- Create flat views in a relational database
- Default memory configurations fail in a low resource environment HOT 4
- Refactor the pipelines (batch and incremental) to have fixed number of workflows instead of multiple HOT 1
- Question: How to run the `pipelines/controller` for sync-ing a FHIR Server to another FHIR Server? I saw that it is possible in the `pipelines/batch` HOT 7
- Fix SonarQube issues found in `pipelines` and `bunsen` submodules.
- Feature for registering flat views in pipelines
- The pipeline metrics in the UI are showing with value as NaN instead of the actual value HOT 1
- Build failure HOT 6
- Windows platform path issue due to the wildcard pattern(*/*) used in pipelines controller package (DwhFilesManager.java) HOT 1
- Batch only produces one FHIR resource type HOT 8
- Implement progress bar feature for the FHIR-Search mode as well
- Investigate and prioritize fixing of docker image vulnerabilities reported by GCP artifact registry HOT 1
- When creating resource tables on start-up, DWH dirs with errors should be skipped.
- Pipeline runs on Windows OS platform gives few warnings
- Enable CI pipeline to run build and tests on a Windows platform
- `pipelines/batch` uber JAR facing error when running the 2nd time of synchronizing FHIR Server A to FHIR Server B (re-sync) HOT 3
- In every FHIR resources being copied from A to B, is it good enough to add capability to overwrite `meta.source` as such it tells where does the FHIR resource actually sourced from? HOT 2
- Investigate/Optimize the number of reshuffle operations for writing to Parquet files for incremental runs
- Enable the pipelines for Flink non-local execution modes as well
- The pipeline fails with `Out of Heap Space` error for high number of FHIR resources
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fhir-data-pipes.