Code Monkey home page Code Monkey logo

Comments (4)

kimaina avatar kimaina commented on May 28, 2024

@mozzy11 adding more comments made on slack

one minor issue
we don't need to define a default value for the parquet out put file path here,like it's done in batch here
since for now ,syncing to a Fhir Sink depends on whether the parquet out put file path is empty .
That means if i want to sync to a fhir sink , i simply dont pass the --fileParquetPath in the commandline params ..by default it defaults to null hence can sync to a fhir sink .the same way it is done in batch Mode
another minor issue
for uniformity through all the three sub-modules,
we should include the path as part of the base server url ,so this --openmrsServerUrl arg should default to "http://localhost:8099/openmrs" not "http://localhost:8099"
and also this --openmrsfhirBaseEndpoint arg should default to "/ws/fhir2/R4" not "/openmrs/ws/fhir2/R4" as its done here (edited)

from fhir-data-pipes.

mozzy11 avatar mozzy11 commented on May 28, 2024

oh ya sure , that was a minor quick fix ,for the way things are .

from fhir-data-pipes.

mozzy11 avatar mozzy11 commented on May 28, 2024

cc @kimaina #85

from fhir-data-pipes.

mozzy11 avatar mozzy11 commented on May 28, 2024

Thanks @kimaina for the review

from fhir-data-pipes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.