Move debezium specific settings to the json config file about fhir-data-pipes HOT 9 CLOSED

ya sure , actually all the above commandline flags i mentioned above where not cleaned out

from fhir-data-pipes.

@kimaina @bashir2 kindly review #57

from fhir-data-pipes.

@gitcliff great work done here.
now that you moved the debezium settings to a json file ,
was there any reason to leave these commandline args here ??

@Parameter(names = { "--databaseHostName" }, description = "Host name on which the source database runs")
		public String databaseHostName = "localhost";
		
		@Parameter(names = { "--databaseUser" }, description = "User name of the host Database")
		public String databaseUser = "root";
		
		@Parameter(names = { "--databasePassword" }, description = "Passowrd for the user of the host Database")
		public String databasePassword = "debezium";
		
		@Parameter(names = { "--databaseSchema" }, description = "Name the Schema")
		public String databaseSchema = "openmrs";
		
		@Parameter(names = { "--snapshotMode" }, description = "criteria for running DB snapshot, options include: "
		        + "when_needed, schema_only, initial, never, e.t.c. To read events from day 0 of db data-entry, use 'initial'. "
		        + "To read only new events, use 'schema_only' ")
		public String snapshotMode = "initial";

And also UPdating the read me ,and actually pointing to the new config file for dbz configs

from fhir-data-pipes.

@gitcliff ,you would also update the params in the docker-compose file here

from fhir-data-pipes.

and see more comments on the PR . with your changes , the pipeline doesnt actually listen to changes

from fhir-data-pipes.

we may need to temporarily revert your PR , and first fix it

from fhir-data-pipes.

Thanks @mozzy11 for flagging this. Yes if we cannot fix this quickly, let's revert and re-submit again.
Re. cleaning up the command line flags, we actually discussed this during the review but I think not all flags were cleaned up.

from fhir-data-pipes.

here is the folloup fix #120

from fhir-data-pipes.

closing this issue as it was fixed

from fhir-data-pipes.