Code Monkey home page Code Monkey logo

Comments (3)

chaoticbob avatar chaoticbob commented on July 24, 2024

Yeah, this seems like an oversight. Most of our tests don't really ever go past a few descriptors.

from bigwheels.

chaoticbob avatar chaoticbob commented on July 24, 2024

I checked the Vulkan and D3D12 code for this.

It looks like for Vulkan - the expectation was for the driver to fail if the allocation exceeded the pool capacity:
https://github.com/google/bigwheels/blob/main/src/ppx/grfx/vk/vk_descriptor.cpp#L109-L116

D3D12 has some amount of checking for pool capacity for when a decriptor set is allocated - there may possibly be a bug:
https://github.com/google/bigwheels/blob/main/src/ppx/grfx/dx12/dx12_descriptor.cpp#L74-L96

from bigwheels.

Keenuts avatar Keenuts commented on July 24, 2024

It looks like for Vulkan - the expectation was for the driver to fail if the allocation exceeded the pool capacity:

https://github.com/google/bigwheels/blob/main/src/ppx/grfx/vk/vk_descriptor.cpp#L109-L116

For Vulkan that's a bit tricky:
The driver should fail when going over the maxCount limit.
However the driver may fail if you go over 1 type capacity.
Here the maxCount was 512*3, as we allocated 512 of each.
But we allocated 600+ samplers. Meaning we didn't went above the maxCount, but above 512.

Thought soo too but apprently WAI because of the "may" in the spec. Don't understand the logic to have a pool with types and not enforce it but meh 🤷‍♂️
https://gitlab.freedesktop.org/mesa/mesa/-/issues/8411

from bigwheels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.