google-code-export / activeweb Goto Github PK

so that we can write: ${app_context.blah} in view to access various objects

If ACTIVE_ENV is set to a value without equivalent in DbConfig, there is an NPE:

activeweb.InitException: failed to create a new instance of class: 
app.config.AppBootstrap: class java.lang.NullPointerException:null

        at java.util.Hashtable.put(Hashtable.java:394)

        at java.util.Properties.setProperty(Properties.java:143)

        at app.config.DbConfig.getTestingProperties(DbConfig.java:38)

        at app.config.DbConfig.init(DbConfig.java:17)

        at app.config.AppBootstrap.init(AppBootstrap.java:18)

        Truncated. see log file for complete stacktrace

Caused By: java.lang.NullPointerException

        at java.util.Hashtable.put(Hashtable.java:394)

        at java.util.Properties.setProperty(Properties.java:143)

        at app.config.DbConfig.getTestingProperties(DbConfig.java:38)

        at app.config.DbConfig.init(DbConfig.java:17)

        at app.config.AppBootstrap.init(AppBootstrap.java:18)

        Truncated. see log file for complete stacktrace

this is because the initialization is client code, and it needs to fail the app 
if it itself fails

needs to log the method that is invoked, because log coming out of AW only 
lists the "index" method

What steps will reproduce the problem?
1.render("activity_content").noLayout(); //this works
2.render("activity_content", new HashMap()).noLayout(); //this all of the 
sudden breaks with FileNotFound exception

We expect the render(String, Map) to act the same way as render(String) does so 
if i decide to add a map to my previous render() method then nothing should 
break.

What version of the product are you using? On what operating system?
1.1

this needs to be dome in HttpSupport, as well as testing framework

proposed behavior:

<@flash name="greeting">
This is a greeting for ${user}
</@>

This also expects that the tag would process a body dynamically with 
interpolation.

Create a simple GWT integration example app

must look at the x-requested-with=XMLHttpRequest header and render error as is, 
without layout.

The x-requested-with header is could be  in capitalized: X-Requested-With

While it is possible to execute any controller/action, it is impossible to 
add parameters as a query string 
This would be pretty nice:

controller("blah").queryString("name=value&name1=value1")....

Error message thrown from Router.java:186 is missing a single quote.


184            if (action != null && !(action.equals("new_form") || 
action.equals("edit_form"))) {
185                throw new IllegalArgumentException("Illegal action name: '" 
+ action +
186                        ", allowed names for restful controllers: 'new_form' 
and 'edit_form'");
187            }

The single quote should be between the double-quote and the comma at the 
beginning of the line.

"',

Low priority. I realize this is a nit-pick. 

Thanks for the great framework!

Phil 

Prevent view(), assign(), render(), redirect(), etc. inside 
ControllerFilter.after() this is because the controller already
rendered.

this will be called when the app goes down - with server or being undeployed

You can fix it easily, by adding next statements in LinkToTag.java

if(params.get("html_id")!= null){
            tf.attribute("id", params.get("html_id").toString());
        }
        tf.addAttributesExcept(params, "controller", "action", "form", "id", "method",
                "query_string", "query_params", "context_path", "destination",
                "before", "before_arg", "after", "after_arg", "confirm", "error", "html_id");

(code from FormTag.java)

this is to improve testing

this is during tests, needs to be pre-pended so that the path() looked the same 
during the test as during runtime. 

Implement FreeMarker exception handler

What steps will reproduce the problem?
1.I am using @link_to tag with some destination(ajax call)
2. In controller I do some action and want to render template, where some 
session variable used, as I see in case of Ajax request session variables are 
not copied in context(opposite general request). I mean 
ParamCopy.copyInto((controllerResponse.values())); isn't called


I didn't sure is it issue at all, but I want to hear your oppinion.
I can directly put in view my session object, anyway, 
view("sessionAtr", session().get("sessionAttr"));

But I didn't sure is it proper.

this is to eliminate duplication in DB configurations

this can be implemented similarly to statistics collection in ActiveJDBC.

Can be done as a global filter: StatisticsFilter 

Develop Maven archetype for ActiveWeb

Add ability to change logging parameters at run time

switch request parameters on/off
switch headers parameters on/off
switch controller execution on/off
switch filter execution on/off

this:
WARN YieldTag - Failed to find content for:...
is annoying, of some pages are not sending content_for

change log level to debug

currently it returns 500:

[INFO] Caused by: java.lang.NoSuchMethodException: 
app.controllers.TemplateController.show()
[INFO]  at java.lang.Class.getMethod(Class.java:1581)
[INFO]  at activeweb.ControllerRunner.executeAction(ControllerRunner.java:204)

this conversion should not even take place because java.util.Date is not DB 
-related. 
The fix is to remove conversion all together and throw IllegalArgumentException 
in case someone sticks java.utul.Date into DB class. The Model class however 
needs to have friendlier conversion methods

this breaks compilation on Windows

implement addGlobalFilters(new TimingFilter()).except(MyController.class, 
BooksController.class, etc.);

refresh packages on each request if active_reload is set to true

Current message is confusing

this will make init code cleaner

makes sense to do it on filter rather than baking into the framework

this is to allow to catch more runtime problems thank with just exceptions

Add a JSP to project, and make that JSP fail, see NPE

this includes before, after and onException methods

this needs to be configurable - boolean argument for a cinstructor:

new DBConnectionFilter("dbname", true) => to manage transaction.

in some cases, the tested code needs to operate transactions. ActiveWeb default 
behavior gets in the way, and there is no way to turn it off. 

this will allow for better debugging in environments other than development

activeweb.ControllerLoadException: java.lang.ClassNotFoundException: 
com.sun.tools.javac.Main
    at activeweb.ControllerFactory.getControllerClass(ControllerFactory.java:56)
    at activeweb.ControllerFactory.createControllerInstance(ControllerFactory.java:62)
    at activeweb.Router.recognize(Router.java:66)
    at activeweb.RequestDispatcher.doFilter(RequestDispatcher.java:95)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
    at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
    at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
    at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
    at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:440)
    at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
    at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
    at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)

this was an oversight in API design

need to be able to do this:
<#if activeweb.environment = 'development'> ... </#if>

this needs to happen on setInjector() call

all the tag names used in the 
http://code.google.com/p/activeweb/source/browse/trunk/activeweb/src/main/java/a
ctiveweb/freemarker/FreeMarkerTemplateManager.java
need to be added to Keywords class:
http://code.google.com/p/activeweb/source/browse/trunk/activeweb/src/main/java/a
ctiveweb/KeyWords.java

the system property seems not matching what the framework does

this will allow to save uploaded content to a file. 
another version: FormItem.saveTo(File)

WARN ParamCopy - found 'session' value set by controller. It is reserved by 
ActiveWeb and will be overwritten


this needs to be investigated, this shows up in logs when session is not set in 
controller

(09:14:45 PM) [email protected]/102ED2CB: ...I should probably think it over
(09:14:55 PM) [email protected]/102ED2CB: maybe a better solution is necessary
(09:15:13 PM) [email protected]/102ED2CB: something like a 
FreeMarkerConfig.init()   - in tests  this needs to be called automatically in 
cases where integrateViews() is set.
(09:15:21 PM) [email protected]/102ED2CB: where you register all your tags
(09:15:28 PM) [email protected]/102ED2CB: and this is called in SpecHelper
(09:15:31 PM) [email protected]/102ED2CB: always
(09:15:58 PM) [email protected]/102ED2CB: do that you had the same tags 
available in tests, as at runtime, even if you do not have filters
(09:16:09 PM) [email protected]/102ED2CB: this is because pages can/do have 
tags

http://guides.rubyonrails.org/layouts_and_rendering.html#using-head-to-build-hea
der-only-responses

http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html

hard to pass ID to a controller

Add controller and action to TimingFilter info