NetSocket connect_to_host fails on windows when plugin is enabled about webrtc-native HOT 6 CLOSED

I cherry picked Faless/godot@abcb079 into the latest godot master godotengine/godot@930d6d8 and recompiled. I can confirm that WebRTC now appears to function normally on windows. As expected, no impact on linux.

Tested both the regular multiplayer bomber demo and the RTC version.

@Faless: Thank you very much! I'd be happy to do more testing, if required.

from webrtc-native.

@Faless: After doing some additional testing, it looks like the connection_error() signal is no longer emitted if the connection fails during the initial connection. If the server disconnects after a connection is successful, connection_closed() seems to fire just fine.

Steps to reproduce:

1. Create build with cherry picked Faless/godot@abcb079
2. Open bomber-rtc project
3. Connect to a server that does not exist.
4. Lobby will open, but no errors will appear.

Reproduced with bomber_rtc example and the build I referenced in my last comment.

from webrtc-native.

After doing some additional testing, it looks like the connection_error() signal is no longer emitted if the connection fails during the initial connection.

@dryw That seems to be a different issue (it happens on alpha2 without the fix, and with the plugin disabled), please open a new issue in the appropriate repository (either demo projects as a start, or godot repo directly if you can confirm it's a bug in WebSocketClient.connect_to_url).

from webrtc-native.

@Faless: I agree that this is a different issue having to do with WebSocketClient or the demo project rather than WebRTC. I will try to reproduce and open an issue on the appropriate repo. Thanks!

from webrtc-native.

Closed via godotengine/godot#33070

from webrtc-native.

Thanks all. Did the fix make into yesterdays Alpha 3 release? Or direct to where / how I should test on my end. Edit: Ah nevermind this will be in Alpha 4.

from webrtc-native.