Godot version 4.1.3.stable.official Plugin vers

I can't seem to be able to reproduce using the <a href="https://github.com/godotengine

ICE exchange does not work properly when a native client creates an offer to a browser about webrtc-native HOT 5 CLOSED

godotengine commented on June 3, 2024

ICE exchange does not work properly when a native client creates an offer to a browser

from webrtc-native.

Comments (5)

Faless commented on June 3, 2024

I can't seem to be able to reproduce using the webrtc_signaling demo, tested with both Chromium and Firefox

from webrtc-native.

ChrisTrenkamp commented on June 3, 2024

Indeed, I took the signaling demo, created a HTML5 export of it, and tweaked the NodeJS server to serve the HTML5 export with a static file endpoint, and everything seems to work fine.

I guess I'm doing something wrong in my demo, but it's not immediately obvious what it is.

from webrtc-native.

ChrisTrenkamp commented on June 3, 2024

I just realized that the WebRTCPeerConnection.ice_candidate_created signal is not triggering, and it's because I forgot to call mp_connections.get_peer(MultiplayerPeer.TARGET_PEER_SERVER).get("connection").set_local_description(type, sdp) in the client. After adding that line, it works in the browser.

Out of curiosity, why do the native clients work fine without setting the local description?

from webrtc-native.

Faless commented on June 3, 2024

Out of curiosity, why do the native clients work fine without setting the local description?

IIRC that is a quirk in the library we use, i.e. there is (was?) no way to create an offer without calling set_local_description.

We should investigate if that changed in recent versions, or if we can ask upstream to allow that.

from webrtc-native.

Faless commented on June 3, 2024

See:

webrtc-native/src/WebRTCLibPeerConnection.cpp

Lines 233 to 239 in cf23e5e

    
           Error WebRTCLibPeerConnection::_set_local_description(const String &p_type, const String &p_sdp) { 
        
           	ERR_FAIL_COND_V(!peer_connection, ERR_UNCONFIGURED); 
        
           	// XXX Library quirk. It doesn't seem possible to create offers/answers without setting the local description. 
        
           	// Ignore this call for now to avoid crash (it's already set automatically!). 
        
           	// peer_connection->setLocalDescription(p_type == String("offer") ? rtc::Description::Type::Offer : rtc::Description::Type::Answer); 
        
           	return OK; 
        
           }

from webrtc-native.

Recommend Projects

ICE exchange does not work properly when a native client creates an offer to a browser about webrtc-native HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	Error WebRTCLibPeerConnection::_set_local_description(const String &p_type, const String &p_sdp) {
	ERR_FAIL_COND_V(!peer_connection, ERR_UNCONFIGURED);
	// XXX Library quirk. It doesn't seem possible to create offers/answers without setting the local description.
	// Ignore this call for now to avoid crash (it's already set automatically!).
	// peer_connection->setLocalDescription(p_type == String("offer") ? rtc::Description::Type::Offer : rtc::Description::Type::Answer);
	return OK;
	}