Library allows add_peer() when connection_state is not WebRTCPeerConnection.STATE_NEW. about webrtc-native HOT 3 CLOSED

It would take a bit of work to thin it down to just that WebRTCmultiplayerclient example. It would be easy to show if there was a minimal WebRTC multiplayer example in the networking demo projects, and to keep it self-contained it could use WebSockets as the signalling system

You mean the WebRTC signaling demo?

from webrtc-native.

I've finally got the example derived from the signalling demo with an ugly toggle button "Addpeerbeforesetdescription" to swap the order of the function calls.

webrtc_signaling (copy).zip

I've used a peerslist = {} to keep track of the peers created, instead of fetching them back using the WebRTCMultiplayer.get_peer(id).connection function.

It's necessary to call WebRTCPeerConnection.add_peer(peer) before peer.create_offer()

However on the receiving end of the Offer your library lets me get away with add_peer() after set_remote_description():

  var rtc_mp = WebRTCMultiplayer.new()
  peer.set_remote_description("offer", offer)
  rtc_mp.add_peer(peer, id)

I have confirmed that the HTML5 implementation does not work for this, but your library does.

To run the HTML5 version:

• Run a copy of WebRTC_signalling_demo on the command line and click on the Signalling server: Listen button.
• Run the exported HTML5
• Hit Start on the top left panel
• Paste the string after Joined lobby into the Room Secret line edit box
• Hit Start on the top right panel
• ... then some stuff happens (or doesn't) to indicate a WebRTC connection has been established.

This is now running on Godot version 3.4.

The reason this issue matters is it's easier to develop WebRTC code against this plugin than on the HTML5 platform, so this is where people are going to be looking for their bugs.

from webrtc-native.

This is fixed in the master branch which uses libdatachannel as rtc library, tested with Godot 3.5.1 and plugin version 1.0.0-beta5.

from webrtc-native.