godaddy / breakdancer Goto Github PK

React Native provides a Dimension.get() function to get viewports of a native app: https://facebook.github.io/react-native/docs/dimensions.html#get
Can we add RN support on breakdancer using that function?

"breakpoint.breakpoint" should be "breakpoints.breakpoint"

https://github.com/godaddy/breakdancer/blame/master/README.md#L141
https://github.com/godaddy/breakdancer/blame/master/README.md#L144

This repository does not expose the library as a module to be used as a link in a browser, nor does it convert the source to ES5 compatible code to be use as a library via node_modules. The only way this repository could be used then is if the consumer provided such logic.

The latest version of breakdance added react-native as a peer dependency.
Given breakdance supports both web and react-native "platforms" (AFAIK), I'd say this dependency is not desired.
Another issue is that version 0.46.1 of react-native requires react 0.16.x and react version 0.15.x was also added as a peer dependency of breakdance, which causes issues while installing it anyway.

I honestly don't know, off the top of my head, the right solution to make breakdancer support RN while not forcing users of the library to have to depend on it, I'm not very experienced with projects that support both platforms, but I'd love to help with a PR if a good solution is suggested.