goctionni / sugarvalidator Goto Github PK

output: " <<myMacro found, but could not find macro or widget definition for tagname "

but macro is defined in javascript
Macro.add("myMacro", {
...
});

This is a feature request. If the validator finds any errors, please return a non-zero exit code. That would make it much easier to use the validator in scripts, such as within GitHub Actions.

For warnings, you could either return a different non-zero exit code if there are no errors but there are warnings, or you could add a command line switch for the user to indicate whether warnings should be treated as errors or not.

Being able to check arbitrary text and Twee files would make this tool useful as part of a general build process when using a CLI compiler.

Trying to validate a sugarcube game I decomplied. The findAllCustomMacros function is not finding the macro definitions. Here's the hack I put in to get the macros. Pretty sure this is ignoring the tag attribute, but this removes the false errors for my validation.

        let startIndex = 0;
        let index = userscript.indexOf(macroStartSyntax, startIndex);
        while (index !== -1) {
            if (index === -1) return;
            let innerStartIndex = index + macroStartSyntax.length;
            const possibleEndIndex = userscript.indexOf(',', innerStartIndex);
            const macroCode = userscript.substring(innerStartIndex, possibleEndIndex).replace(/["']/g, "").trim();
            addSimpleMacro(macroCode, false)
            startIndex =  possibleEndIndex;
            index = userscript.indexOf(macroStartSyntax, startIndex);
        }

Not sure why it isn't already, but I feel like you should make this an NPM package so users can integrate it more easily into their build process and have it managed via NPM rather that just downloading the files and manually checking for updates and such. You'd probably need to expose both an API and a CLI for users.