Issue Type

• Feature enhancement

Summary

@varshavaradarajan brought this up: "We should do this for the helm chart for agents - https://pracucci.com/graceful-shutdown-of-kubernetes-pods.html. For server, we recreate (instead of rolling update), so, it terminates existing server container, also abruptly, and brings up a new one with the existing config and db. Might result in some db corruption if it terminates abruptly. May be we can have a pre-stop hook to call stop-server.sh instead?"

/cc @sheroy - What do you think?

Issue Type

• Feature enhancement

Summary

We have been using the APIs that were available in beta with K8s 1.8:

• https://github.com/kubernetes/charts/blob/master/stable/gocd/templates/ingress.yaml
• https://github.com/kubernetes/charts/blob/master/stable/gocd/templates/gocd-server-deployment.yaml
  etc

With k8s 1.9, some of these are out of beta. We ought to move to support K8s 1.9 onwards.

Type

• Bug Report

Description

GoCD Helm Chart exposes GoCD application to the external world through Ingress. Which supports only http connections.
GoCD agents are unable to connect to the server running on kubernetes cluster as HTTPS port is not exposed!

Currently Chart.yaml uses https://cdn.rawgit.com/gocd/gocd-chocolatey/43ae0ef2/go-logo-192px.svg. Might make sense to move this icon into this repository's docs/ directory and use that instead?

Issue Type

• Feature enhancement

Summary

The helm chart installs gocd/gocd-server and gocd/gocd-agent-alpine-* by default. These images are publicly available on dockerhub . Suppose a user wants to override the image to pull from a private registry, there is no option to do so. While secrets can (and should) be created outside of the helm chart installation, there is no imagePullSecrets in the (server|agent)-deployment yaml to reference the created secret.
Related: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

Don't know how necessary this is to do though seeing as no one has raised a request for it.

Basic environment details

• Chart Version: latest